Skip to content

Forward-port the 17.0.1 changelog section to main - #4814

Merged
justin808 merged 1 commit into
mainfrom
claude/4813-changelog-17-0-1-forward-port
Jul 29, 2026
Merged

Forward-port the 17.0.1 changelog section to main#4814
justin808 merged 1 commit into
mainfrom
claude/4813-changelog-17-0-1-forward-port

Conversation

@justin808

@justin808 justin808 commented Jul 29, 2026

Copy link
Copy Markdown
Member

Fixes #4813

What changed and why

main's CHANGELOG.md skipped from [Unreleased] straight to [17.0.0] because the
17.0.1 release-reconciliation PR onto main was never opened (v17.0.1 shipped from
release/17.0.1, tag v17.0.1 = 88c0de5b8994d7ed9bcd2cc2405d2e520e1bf20a, but that
work never landed on main). This PR is pure changelog bookkeeping:

  • Copied the ### [17.0.1] - 2026-07-26 section verbatim from
    origin/release/17.0.1:CHANGELOG.md (the OSS react-on-rails npm MIT license
    correction, PR Fix OSS npm package license metadata #4792) and placed it between [Unreleased] and [17.0.0] - 2026-07-16.
  • Added the [17.0.1] compare link in sorted position, right above [17.0.0].
  • Corrected the stale [unreleased] compare link (v17.0.0...main
    v17.0.1...main), matching the precedent release/17.0.1's own CHANGELOG.md already
    set for that link when it bumped.
  • No [Unreleased] entries were moved: main's [Unreleased] block does not already
    contain the 17.0.1 entry (verified below), so nothing needed relocating.

Evidence

Version headers before/after (grep -n '^### \[' CHANGELOG.md | head):

Before (base 822b4c30):

25:### [Unreleased]
261:### [17.0.0] - 2026-07-16
931:### [16.6.0] - 2026-04-09

After:

25:### [Unreleased]
261:### [17.0.1] - 2026-07-26
271:### [17.0.0] - 2026-07-16
941:### [16.6.0] - 2026-04-09

Prettier:

$ pnpm exec prettier --check CHANGELOG.md
Checking formatting...
All matched files use Prettier code style!

git diff --stat against base 822b4c30bc3764a08454a7e891834b2699921a03:

 CHANGELOG.md | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

No runtime source in this diff — only CHANGELOG.md is touched.

Verbatim-insertion check: diffed the inserted ### [17.0.1] section (headers through
the PR #4792 entry) against the same range in origin/release/17.0.1:CHANGELOG.md
identical, zero-line diff.

Tag verification:

  • v17.0.1 = 88c0de5b8994d7ed9bcd2cc2405d2e520e1bf20a (matches the issue and envelope).
  • v17.0.0 = d2e64e4043bcd22ea9e81c44d14f234cf3c361a5 (used by the pre-existing
    [17.0.0] compare link, confirmed unchanged).

Already-shipped [Unreleased] entries: none found. Searched main's [Unreleased]
block for the PR #4792 / "OSS npm package license metadata" text — no match. (An
unrelated [Pro] Configurable license-token secret sources entry, PR #4552, also
mentions "license" but is a different, still-unreleased feature — not the 17.0.1 fix.)

Pre-commit/pre-push hooks (lefthook) ran clean: trailing-newlines, markdown-links,
prettier on commit; branch-lint, markdown-links on push.

Labels: none

Docs/changelog-only change; no code labels apply.

Codex Decision Log

Question: The envelope's worked example only called out fixing the [17.0.0]
compare link and adding [17.0.1]. Main also has a stale [unreleased]: ...v17.0.0...main
link at the bottom of the file that logically should advance to v17.0.1...main now that
[Unreleased] sits after [17.0.1] in the document structure. Is that in scope?

Decision: Fixed it as part of this PR.

Why: It's the same file, the same "fix link references at the bottom of the file"
instruction, a one-line mechanical correction, and release/17.0.1's own CHANGELOG.md
already made the identical correction ([unreleased]: ...v17.0.1...main) when it
bumped — so this brings main in line with the established precedent rather than
introducing a new convention.

What a maintainer may want to revisit: If this single extra line is considered
out of the tightly-scoped envelope, it can be reverted with a one-line diff; everything
else in this PR is independent of it.

Confidence note:

  • Validated: git fetch --prune origin main release/17.0.1; git rev-parse v17.0.1
    and v17.0.0 (both resolved and match expected SHAs); pnpm install --prefer-offline
    (succeeded, required for the prettier pre-commit hook); pnpm exec prettier --check CHANGELOG.md (pass, both before commit and after final edit); git diff --stat
    against pinned base SHA (CHANGELOG.md only, 12 insertions/1 deletion); manual diff of
    the inserted [17.0.1] section against origin/release/17.0.1:CHANGELOG.md (identical);
    grep of main's [Unreleased] block for PR 4792 / license text (no match — nothing to
    move); agent-coord status --target 4813 checked twice (before editing and
    immediately before push) — claim holder maker-lane-4813-changelog-171 confirmed
    both times; git commit and git push ran with lefthook pre-commit/pre-push hooks,
    all green.
  • Evidence: inline command output above; issue body fetched via
    gh issue view 4813 --repo shakacode/react_on_rails --json title,body,state,labels
    (matches this envelope's framing exactly, no discrepancies).
  • UNKNOWN: none.
  • Residual risk: none — single-file, additive changelog change; no runtime source
    touched; verbatim-copy verified byte-for-byte against the release branch.

Summary by CodeRabbit

  • Bug Fixes

    • Corrected open-source package license metadata.
    • Ensured package distributions do not inherit commercial licensing terms.
  • Documentation

    • Added release notes for version 17.0.1.
    • Updated changelog comparison links.

Merge qualifications (coordinator)

Release gate applied: beta. Target branch is main, whose release phase is beta per
AGENTS.md -> Release-Train Branching And Phase Gating. The beta row requires the lowest
gate: confidence note + green required checks. Both are satisfied — the confidence note is
above, and required-pr-gate passed with zero failing checks at head
d7555e71058b0431187bdd410aa035611c2f3ef9.

Release mode: development. The only open release tracker is #4806, whose final release
target is 17.0.1 — already shipped (tag v17.0.1 = 88c0de5b8994d7ed9bcd2cc2405d2e520e1bf20a).
Per AGENTS.md, an unrelated final-release target does not block work whose own target is
clear; this PR targets main on the 17.1 line, for which no tracker exists, so development
applies. The accelerated-RC confidence block is therefore not required.

Merge ledger: script/pr-merge-ledger 4814 --strict --changelog-classification not_user_visible
-> complete_allowed: true, zero violations, zero unknown fields, CI verdict READY, zero
unresolved current-head review threads, no changes_requested.

Changelog classification: not_user_visible. Supplied explicitly by the coordinator.
Release-reconciliation bookkeeping is release-process per the AGENTS.md taxonomy and
introduces no user-visible behavior needing its own [Unreleased] entry.

Coordinator verification (independent of the authoring worker): re-extracted the
[17.0.1] section from both origin/release/17.0.1 and this PR head and diffed them
(identical); confirmed CHANGELOG.md is the only changed path; confirmed v17.0.0 and
v17.0.1 both resolve; independently confirmed main's [Unreleased] never contained the
shipped PR 4792 entry, so the "move not copy" requirement was vacuous here.

UNKNOWN carried forward: the installed Agent Workflows pack ships an
autonomous-merge-eligibility gate that this repository has not adopted — none of its
required runtime-trust paths (.agents/skills/pr-batch/bin/autonomous-merge-eligibility,
.agents/skills/pr-batch/lib/autonomous_merge_decision.rb,
.agents/bin/agent_doctor/autonomous_merge_policy.rb, and the calibration fixture) exist in
origin/main, so its runtime-trust binding cannot verify here by construction. This merge
therefore rests on the repository's own adopted contract (AGENTS.md phase gate +
script/pr-merge-ledger --strict), not on that helper. Recorded rather than silently skipped.

Batch: ror-a-17-1-wave-a-20260729, lane lane-4813-changelog-171. merge_authority: auto_merge_when_gates_pass.

The 17.0.1 release shipped from release/17.0.1 (tag v17.0.1 =
88c0de5) but the release-reconciliation
PR onto main was never opened, so main's changelog jumped from
[Unreleased] straight to [17.0.0].

- Copy the [17.0.1] - 2026-07-26 section verbatim from
  origin/release/17.0.1:CHANGELOG.md (OSS react-on-rails npm MIT license
  correction, PR 4792).
- Add the [17.0.1] compare link in sorted position.
- Correct the stale [unreleased] compare link (v17.0.0...main ->
  v17.0.1...main), matching the precedent already set in
  release/17.0.1's CHANGELOG.md.

Fixes #4813
Copilot AI review requested due to automatic review settings July 29, 2026 13:08

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

Changes

Release changelog reconciliation

Layer / File(s) Summary
17.0.1 release entry and links
CHANGELOG.md
Adds the dated 17.0.1 fixed entry and updates the Unreleased and 17.0.1 comparison links.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: copilot, abanoubghadban, ihabadham

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The changelog-only update adds the 17.0.1 section and compare links on main, matching issue #4813 and its acceptance criteria.
Out of Scope Changes check ✅ Passed The PR stays within scope by changing only CHANGELOG.md and avoids runtime or version-file changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: forward-porting the 17.0.1 changelog section to main.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/4813-changelog-17-0-1-forward-port

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Jul 29, 2026

Copy link
Copy Markdown

Greptile Summary

Adds the previously omitted 17.0.1 release notes and updates the changelog comparison references to use v17.0.1 as the latest release.

Confidence Score: 5/5

The changelog-only PR appears safe to merge.

The release section and reference links follow the surrounding changelog conventions, with no runtime changes or actionable documentation defects introduced.

Important Files Changed

Filename Overview
CHANGELOG.md Adds a correctly ordered and formatted 17.0.1 section, advances the Unreleased comparison base, and adds the matching release comparison link.

Reviews (1): Last reviewed commit: "Add 17.0.1 changelog section to main (fo..." | Re-trigger Greptile

@claude

claude Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Review: Forward-port the 17.0.1 changelog section to main

Overview

Pure CHANGELOG.md bookkeeping to fix main's changelog, which jumped from [Unreleased] straight to [17.0.0] because the 17.0.1 release-reconciliation PR never landed on main (v17.0.1 shipped from release/17.0.1). The PR:

  • Inserts the ### [17.0.1] - 2026-07-26 section between [Unreleased] and [17.0.0].
  • Adds the [17.0.1] compare link in sorted position above [17.0.0].
  • Updates the stale [unreleased] compare link from v17.0.0...main to v17.0.1...main.

Verification

I independently confirmed the structural claims against the checked-out merge commit:

  • Section headers are in correct chronological order (Unreleased17.0.117.0.016.6.0...).
  • [17.0.1] and [unreleased] link-reference definitions are each defined exactly once (no duplicates).
  • PR 4792 attribution (justin808) matches the actual PR author and merge date (2026-07-26) via gh pr view 4792.
  • Formatting (blank lines, heading levels, bullet style) matches the surrounding entries exactly.

Assessment

  • Correctness: Good. No runtime source is touched; this is additive-only to a single file.
  • Risk: Minimal — changelog-only change, verbatim copy from the already-shipped release branch.
  • Scope: The [unreleased] link correction (not explicitly called out in the original issue) is in scope — it's the same file, a one-line mechanical fix, and matches the precedent already set in release/17.0.1's own CHANGELOG.md. No objection to including it here.
  • Style/conventions: Consistent with existing changelog entries (bold summary line, PR/author links, #### Fixed subsection).

No issues found. This looks safe to merge.

@justin808
justin808 added this pull request to the merge queue Jul 29, 2026
Merged via the queue into main with commit 43ae781 Jul 29, 2026
41 checks passed
@justin808
justin808 deleted the claude/4813-changelog-17-0-1-forward-port branch July 29, 2026 13:24
justin808 added a commit that referenced this pull request Jul 31, 2026
…ills

* origin/main:
  Fix ci-required base ref for PR merge-ref checkouts (#4819)
  Honor response charset and reject non-2xx HTTP-served SSR bundles (#4817)
  [Pro] Redact RSC render-error metadata on the fetched (client-navigation) payload path (#4821)
  Forward-port the 17.0.1 changelog section to main (#4814)
justin808 added a commit that referenced this pull request Jul 31, 2026
…t-policy

* origin/main: (33 commits)
  Fix ci-required base ref for PR merge-ref checkouts (#4819)
  Honor response charset and reject non-2xx HTTP-served SSR bundles (#4817)
  [Pro] Redact RSC render-error metadata on the fetched (client-navigation) payload path (#4821)
  Forward-port the 17.0.1 changelog section to main (#4814)
  Handle selector metacharacters in renderComponent DOM IDs (#4808)
  [Pro] Prevent caching RSC renders with errors (#4804)
  Agents: trust Copilot review identities (#4807)
  Agents: bind fleet closeout to generated pack (#4805)
  Docs: ADR 0002 — Skills-in-package over MCP for agent-native DX (#4735)
  Scope GitHub release commands to the origin repository (#4803)
  Forward-port OSS npm license metadata fix (#4794)
  Add golden-output gate for the serverWebpackConfig generator template (#4790)
  Cover the rspack CSS SSR generator fixes and de-duplicate the loader path (#4788)
  Configure agent workflow repo policy (#4785)
  Forward-port gh include mixed framing from #4684 (#4784)
  Release: enforce one-change forward-port closeout (#4783)
  Forward-port multi-URL rolling-deploy seeding to main (#4782)
  Docs: clarify React 18 streaming without RSC (#4780)
  Docs: forward-port v17 upgrade and generator gate guidance (#4781)
  Record the final React on Rails 17.0.0 changelog (#4742)
  ...

# Conflicts:
#	AGENTS.md
#	internal/contributor-info/release-train-runbook.md
justin808 added a commit that referenced this pull request Aug 6, 2026
…out-vm-pool

* origin/main:
  Docs: move agent coordination to the HTTP backend (#4764)
  Detect unnoticed changes across generated webpack/Rspack configs (#4839)
  Fix durable ShakaPerf release evidence reuse (#4833)
  Docs: add missing content — release notes, upgrade guide, config, API references (#4843) (#4844)
  Fix incorrect docs: helper names, defaults, requirements, runtime refs (#4836)
  Scroll-priority streaming: candidate architecture evaluation (#4835) (#4841)
  Fix generated server config lint cleanup (#4840)
  Document serialized release backport policy (#4592)
  Package version-matched agent skills and docs (#4809)
  Fix ci-required base ref for PR merge-ref checkouts (#4819)
  Honor response charset and reject non-2xx HTTP-served SSR bundles (#4817)
  [Pro] Redact RSC render-error metadata on the fetched (client-navigation) payload path (#4821)
  Forward-port the 17.0.1 changelog section to main (#4814)

# Conflicts:
#	CHANGELOG.md
justin808 added a commit that referenced this pull request Aug 8, 2026
…ential-broker

* origin/main: (75 commits)
  Silence routine startup diagnostics for Rails commands (#4849)
  Docs: move agent coordination to the HTTP backend (#4764)
  Detect unnoticed changes across generated webpack/Rspack configs (#4839)
  Fix durable ShakaPerf release evidence reuse (#4833)
  Docs: add missing content — release notes, upgrade guide, config, API references (#4843) (#4844)
  Fix incorrect docs: helper names, defaults, requirements, runtime refs (#4836)
  Scroll-priority streaming: candidate architecture evaluation (#4835) (#4841)
  Fix generated server config lint cleanup (#4840)
  Document serialized release backport policy (#4592)
  Package version-matched agent skills and docs (#4809)
  Fix ci-required base ref for PR merge-ref checkouts (#4819)
  Honor response charset and reject non-2xx HTTP-served SSR bundles (#4817)
  [Pro] Redact RSC render-error metadata on the fetched (client-navigation) payload path (#4821)
  Forward-port the 17.0.1 changelog section to main (#4814)
  Handle selector metacharacters in renderComponent DOM IDs (#4808)
  [Pro] Prevent caching RSC renders with errors (#4804)
  Agents: trust Copilot review identities (#4807)
  Agents: bind fleet closeout to generated pack (#4805)
  Docs: ADR 0002 — Skills-in-package over MCP for agent-native DX (#4735)
  Scope GitHub release commands to the origin repository (#4803)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Forward-port the 17.0.1 changelog section to main (release reconciliation PR never opened)

2 participants