Docs: ADR 0002 — Skills-in-package over MCP for agent-native DX - #4735
Conversation
Captures the 2026-07-17 maintainer decision on #4605: Skills-in-package plus version-matched bundled docs are the 17.2 agent flagship; a slim MCP stays deferred until the #4603 eval produces evidence. Updates the Agent-native development glossary entry that still presumed MCP as the delivery vehicle. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
WalkthroughChangesAgent delivery policy
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR records the agent-toolchain decision for the 17.2 release. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "Docs: record agent-toolchain v2 decision..." | Re-trigger Greptile |
ReviewScope: internal-docs-only change (2 files, +23/-1), no runtime/CI/published-docs surface. Reviewed for correctness, convention adherence, and internal consistency. OverviewAdds Code quality / convention
Issues / risksNone found. This is a low-risk, well-scoped documentation change:
Suggestions (optional, non-blocking)
Overall: clean, well-structured decision record that matches this repo's existing ADR conventions. No blocking concerns. |
…t-policy * origin/main: (33 commits) Fix ci-required base ref for PR merge-ref checkouts (#4819) Honor response charset and reject non-2xx HTTP-served SSR bundles (#4817) [Pro] Redact RSC render-error metadata on the fetched (client-navigation) payload path (#4821) Forward-port the 17.0.1 changelog section to main (#4814) Handle selector metacharacters in renderComponent DOM IDs (#4808) [Pro] Prevent caching RSC renders with errors (#4804) Agents: trust Copilot review identities (#4807) Agents: bind fleet closeout to generated pack (#4805) Docs: ADR 0002 — Skills-in-package over MCP for agent-native DX (#4735) Scope GitHub release commands to the origin repository (#4803) Forward-port OSS npm license metadata fix (#4794) Add golden-output gate for the serverWebpackConfig generator template (#4790) Cover the rspack CSS SSR generator fixes and de-duplicate the loader path (#4788) Configure agent workflow repo policy (#4785) Forward-port gh include mixed framing from #4684 (#4784) Release: enforce one-change forward-port closeout (#4783) Forward-port multi-URL rolling-deploy seeding to main (#4782) Docs: clarify React 18 streaming without RSC (#4780) Docs: forward-port v17 upgrade and generator gate guidance (#4781) Record the final React on Rails 17.0.0 changelog (#4742) ... # Conflicts: # AGENTS.md # internal/contributor-info/release-train-runbook.md
|
Completed-batch audit: replay evidence follows. |
…ential-broker * origin/main: (75 commits) Silence routine startup diagnostics for Rails commands (#4849) Docs: move agent coordination to the HTTP backend (#4764) Detect unnoticed changes across generated webpack/Rspack configs (#4839) Fix durable ShakaPerf release evidence reuse (#4833) Docs: add missing content — release notes, upgrade guide, config, API references (#4843) (#4844) Fix incorrect docs: helper names, defaults, requirements, runtime refs (#4836) Scroll-priority streaming: candidate architecture evaluation (#4835) (#4841) Fix generated server config lint cleanup (#4840) Document serialized release backport policy (#4592) Package version-matched agent skills and docs (#4809) Fix ci-required base ref for PR merge-ref checkouts (#4819) Honor response charset and reject non-2xx HTTP-served SSR bundles (#4817) [Pro] Redact RSC render-error metadata on the fetched (client-navigation) payload path (#4821) Forward-port the 17.0.1 changelog section to main (#4814) Handle selector metacharacters in renderComponent DOM IDs (#4808) [Pro] Prevent caching RSC renders with errors (#4804) Agents: trust Copilot review identities (#4807) Agents: bind fleet closeout to generated pack (#4805) Docs: ADR 0002 — Skills-in-package over MCP for agent-native DX (#4735) Scope GitHub release commands to the origin repository (#4803) ...
Why
The #4605 maintainer decision (2026-07-17) settled how React on Rails ships its agent toolchain for 17.2, but the planning glossary (
internal/planning/CONTEXT.md) still described Agent-native development with MCP as a presumed delivery vehicle, and the decision's trade-off (Skills-in-package vs slim MCP vs docs-only, after #3870's full-MCP rejection) met the bar for a decision record: hard to reverse (Skills become shipped package surface), surprising without context, and a real trade-off.What
internal/adr/0002-skills-in-package-over-mcp.md: records the decision — Skills-in-package + version-matched bundled docs are 17.2 scope; slim MCP deferred pending Tutorial + scripted eval: an AI agent builds a React on Rails Pro app end-to-end, unaided #4603 eval evidence; RFC + build: a React on Rails MCP server (doctor-as-JSON, generators, component scaffold, doc & error-code search) #3870's ruling stands. Includes considered options and revisit triggers.internal/planning/CONTEXT.md: updates the Agent-native development entry, adds an Avoid note, and logs the resolved ambiguity with date and links.Test plan
internal/is not published); no runtime, CI, or published-docs surface🤖 Generated with Claude Code
Summary by CodeRabbit
Merge evidence
development/beta; the standard main-branch gate applies and is satisfied.7dba7a11f3ccaea8f25a143b4be289e55dd14b1e: Claude review, CodeRabbit, and Greptile completed with no confirmed blocker; zero unresolved review threads.not_user_visible— internal decision records only.Confidence note:
pnpm dlx prettier@3.6.2 --check internal/adr/0002-skills-in-package-over-mcp.md internal/planning/CONTEXT.mdpassed at the exact PR head;script/ci-changes-detector origin/mainclassified the diff as documentation-only with no additional CI jobs.required-pr-gate, Markdown format/link checks, Claude review, CodeRabbit, Greptile, and CodeQL are complete;pr-ci-readinessreturnedREADY; no pending viewer review drafts.QA Evidence
Completed-batch audit
Status: Clean — no outstanding findings or follow-ups. Durable receipt.