Skip to content

Docs: ADR 0002 — Skills-in-package over MCP for agent-native DX - #4735

Merged
justin808 merged 1 commit into
mainfrom
docs/adr-0002-agent-toolchain
Jul 26, 2026
Merged

Docs: ADR 0002 — Skills-in-package over MCP for agent-native DX#4735
justin808 merged 1 commit into
mainfrom
docs/adr-0002-agent-toolchain

Conversation

@justin808

@justin808 justin808 commented Jul 18, 2026

Copy link
Copy Markdown
Member

Why

The #4605 maintainer decision (2026-07-17) settled how React on Rails ships its agent toolchain for 17.2, but the planning glossary (internal/planning/CONTEXT.md) still described Agent-native development with MCP as a presumed delivery vehicle, and the decision's trade-off (Skills-in-package vs slim MCP vs docs-only, after #3870's full-MCP rejection) met the bar for a decision record: hard to reverse (Skills become shipped package surface), surprising without context, and a real trade-off.

What

Test plan

  • Prettier clean on both files
  • Internal-docs-only change (internal/ is not published); no runtime, CI, or published-docs surface

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Documented the decision to provide version-matched AI agent skills and bundled documentation with React on Rails packages.
    • Clarified that agents can work end-to-end without external setup through packaged guidance, project instructions, and machine-readable errors.
    • Recorded that a slim MCP integration is deferred pending evaluation results.

Merge evidence

  • Release mode / phase: development / beta; the standard main-branch gate applies and is satisfied.
  • Labels: none — internal documentation only; hosted CI expansion is not required.
  • Review coverage at current head 7dba7a11f3ccaea8f25a143b4be289e55dd14b1e: Claude review, CodeRabbit, and Greptile completed with no confirmed blocker; zero unresolved review threads.
  • Changelog classification: not_user_visible — internal decision records only.
  • Decision points: 0.

Confidence note:

  • Validated: pnpm dlx prettier@3.6.2 --check internal/adr/0002-skills-in-package-over-mcp.md internal/planning/CONTEXT.md passed at the exact PR head; script/ci-changes-detector origin/main classified the diff as documentation-only with no additional CI jobs.
  • Evidence: current-head required-pr-gate, Markdown format/link checks, Claude review, CodeRabbit, Greptile, and CodeQL are complete; pr-ci-readiness returned READY; no pending viewer review drafts.
  • UNKNOWN: none.
  • Residual risk: none; this changes internal planning/ADR text only.

QA Evidence

  • QA lane: not applicable; internal-docs-only dependency PR.
  • Scope checked: both changed internal Markdown files at the exact PR head.
  • Tested at: PR Docs: ADR 0002 — Skills-in-package over MCP for agent-native DX #4735 head 7dba7a1.
  • Automated checks: exact-head Prettier check plus current-head GitHub Markdown, required-gate, review, and CodeQL results.
  • Manual checks: decision/glossary cross-link and changed-path inspection.
  • Findings: none.
  • QA required: no.
  • QA required rationale: internal-only decision documentation with no runtime, package, generated-output, CI, or published-docs behavior.
  • QA lane status: not_applicable.
  • Release-blocking status: not_applicable.
  • Process-gap disposition: not applicable.

Completed-batch audit

Status: Clean — no outstanding findings or follow-ups. Durable receipt.

Captures the 2026-07-17 maintainer decision on #4605: Skills-in-package
plus version-matched bundled docs are the 17.2 agent flagship; a slim
MCP stays deferred until the #4603 eval produces evidence. Updates the
Agent-native development glossary entry that still presumed MCP as the
delivery vehicle.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

Changes

Agent delivery policy

Layer / File(s) Summary
Skills-in-package decision and planning alignment
internal/adr/0002-skills-in-package-over-mcp.md, internal/planning/CONTEXT.md
Adds the 17.2 Skills-in-package decision with version-matched bundled docs, defers slim MCP pending evaluation evidence, and updates agent-native development guidance accordingly.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related issues

  • #4605 — Directly covers the in-package Skills, version-matched bundled docs, and deferred slim MCP proposal documented by this change.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately captures the main documentation change: ADR 0002 choosing Skills-in-package over MCP for agent-native development.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/adr-0002-agent-toolchain

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Jul 18, 2026

Copy link
Copy Markdown

Greptile Summary

This PR records the agent-toolchain decision for the 17.2 release. The main changes are:

  • Adds ADR 0002 for package-bundled Skills and version-matched documentation.
  • Defers a slim MCP until the agent evaluation provides supporting evidence.
  • Aligns the planning glossary and ambiguity log with the decision.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed documentation.
  • The ADR follows the existing structure and its relative links resolve.
  • The planning updates consistently describe the accepted 17.2 direction.

Important Files Changed

Filename Overview
internal/adr/0002-skills-in-package-over-mcp.md Adds an accepted ADR with the decision, alternatives, consequences, and revisit conditions.
internal/planning/CONTEXT.md Updates the agent-native development theme and resolved-ambiguity log to reference ADR 0002.

Reviews (1): Last reviewed commit: "Docs: record agent-toolchain v2 decision..." | Re-trigger Greptile

@claude

claude Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Review

Scope: internal-docs-only change (2 files, +23/-1), no runtime/CI/published-docs surface. Reviewed for correctness, convention adherence, and internal consistency.

Overview

Adds internal/adr/0002-skills-in-package-over-mcp.md, recording the #4605 decision that React on Rails' 17.2 agent toolchain ships as Skills-in-package + version-matched bundled docs, with a slim MCP deferred pending #4603 eval evidence. Updates internal/planning/CONTEXT.md's Agent-native development glossary entry to match and logs the resolved ambiguity.

Code quality / convention

  • The new ADR follows the exact structural convention established by 0001-rspack-answers-vite.md (frontmatter with status/date, title, prose rationale, "Considered options", "Consequences" with an explicit revisit trigger). Nice consistency.
  • The CONTEXT.md edit is minimal and surgical: updates one glossary entry, adds an _Avoid_ line (matching the pattern used by other entries in the file), and appends one line to "Flagged ambiguities" — all consistent with the file's existing structure.
  • Cross-link [ADR 0002](../adr/0002-skills-in-package-over-mcp.md) resolves correctly relative to internal/planning/CONTEXT.mdinternal/adr/0002-...md.

Issues / risks

None found. This is a low-risk, well-scoped documentation change:

Suggestions (optional, non-blocking)

Overall: clean, well-structured decision record that matches this repo's existing ADR conventions. No blocking concerns.

@justin808
justin808 added this pull request to the merge queue Jul 26, 2026
Merged via the queue into main with commit 37ddaf5 Jul 26, 2026
41 checks passed
@justin808
justin808 deleted the docs/adr-0002-agent-toolchain branch July 26, 2026 11:34
justin808 added a commit that referenced this pull request Jul 31, 2026
…t-policy

* origin/main: (33 commits)
  Fix ci-required base ref for PR merge-ref checkouts (#4819)
  Honor response charset and reject non-2xx HTTP-served SSR bundles (#4817)
  [Pro] Redact RSC render-error metadata on the fetched (client-navigation) payload path (#4821)
  Forward-port the 17.0.1 changelog section to main (#4814)
  Handle selector metacharacters in renderComponent DOM IDs (#4808)
  [Pro] Prevent caching RSC renders with errors (#4804)
  Agents: trust Copilot review identities (#4807)
  Agents: bind fleet closeout to generated pack (#4805)
  Docs: ADR 0002 — Skills-in-package over MCP for agent-native DX (#4735)
  Scope GitHub release commands to the origin repository (#4803)
  Forward-port OSS npm license metadata fix (#4794)
  Add golden-output gate for the serverWebpackConfig generator template (#4790)
  Cover the rspack CSS SSR generator fixes and de-duplicate the loader path (#4788)
  Configure agent workflow repo policy (#4785)
  Forward-port gh include mixed framing from #4684 (#4784)
  Release: enforce one-change forward-port closeout (#4783)
  Forward-port multi-URL rolling-deploy seeding to main (#4782)
  Docs: clarify React 18 streaming without RSC (#4780)
  Docs: forward-port v17 upgrade and generator gate guidance (#4781)
  Record the final React on Rails 17.0.0 changelog (#4742)
  ...

# Conflicts:
#	AGENTS.md
#	internal/contributor-info/release-train-runbook.md
@justin808

Copy link
Copy Markdown
Member Author

Completed-batch audit: replay evidence follows.

justin808 added a commit that referenced this pull request Aug 8, 2026
…ential-broker

* origin/main: (75 commits)
  Silence routine startup diagnostics for Rails commands (#4849)
  Docs: move agent coordination to the HTTP backend (#4764)
  Detect unnoticed changes across generated webpack/Rspack configs (#4839)
  Fix durable ShakaPerf release evidence reuse (#4833)
  Docs: add missing content — release notes, upgrade guide, config, API references (#4843) (#4844)
  Fix incorrect docs: helper names, defaults, requirements, runtime refs (#4836)
  Scroll-priority streaming: candidate architecture evaluation (#4835) (#4841)
  Fix generated server config lint cleanup (#4840)
  Document serialized release backport policy (#4592)
  Package version-matched agent skills and docs (#4809)
  Fix ci-required base ref for PR merge-ref checkouts (#4819)
  Honor response charset and reject non-2xx HTTP-served SSR bundles (#4817)
  [Pro] Redact RSC render-error metadata on the fetched (client-navigation) payload path (#4821)
  Forward-port the 17.0.1 changelog section to main (#4814)
  Handle selector metacharacters in renderComponent DOM IDs (#4808)
  [Pro] Prevent caching RSC renders with errors (#4804)
  Agents: trust Copilot review identities (#4807)
  Agents: bind fleet closeout to generated pack (#4805)
  Docs: ADR 0002 — Skills-in-package over MCP for agent-native DX (#4735)
  Scope GitHub release commands to the origin repository (#4803)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant