ci: Update Rust toolchain version to 1.88#99
Closed
sagudev wants to merge 2 commits into
Closed
Conversation
Signed-off-by: Sam <16504129+sagudev@users.noreply.github.com>
mrobinson
approved these changes
Jul 11, 2026
Member
Author
|
I think linux problem is real and it is #88 |
Member
|
I was planning to update mozangle to latest upstream (ESR). Perhaps that wil also fix this issue. |
Signed-off-by: Sam <16504129+sagudev@users.noreply.github.com>
Member
|
Note, the linker failure doesn't happen with rust 1.95, I'm assuming because we are using lld. So probably it's just an issue with the order of libraries on the link line. |
Member
Author
That would make sense, but we want to support more, so we should fix this properly. Can you fix the order here? |
Member
|
Yes, I can post a patch later, once I'm back at the computer, need to do something else first. |
Member
Author
|
Done via #100 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix CI: https://github.com/servo/mozangle/actions/runs/29141242178/job/86514745581#step:5:62