Update vendored angle to FIREFOX_140_12_0esr_RELEASE #100
Conversation
|
I am not sure it's enough to do just patch release here, given that we reexport many stuff from bindgen. Did you check that we are in fact semver compatible (we have much more stuff exposed on windows btw)? Anyway, maybe we should be doing like in mozjs tracking and automating version bumps? Our LTS release follows firefox ESR I presume (mainly for SM and mozangle, but I guess that would could also work for WR and stylo as both can get security updates from upstream - should we make sure we are properly synchronized to ESR branch for the time of LTS release so that backporting is easier). |
|
I was going to say it appears to be additive, but cargo semver-checks does complain:
So, I guess a nice reminder for me that a change looking additive can still be breaking. |
|
this PR needs companion PR in servo, we especially need to test windows builds |
Followed the instruction from the readme, deleting gfx/angle and then re-vendoring by copying the gfx/angle directory from the upstream 140.12.0 ESR firefox release (commit f802561). This does not yet contain our patches.
|
Companion PR servo/servo#46455. I also tested locally on a windows machine, and servoshell seemed to work fine. |
|
@sagudev could you do a new crates.io release when you have time? |
|
Published! |
Followed the instruction from the readme, deleting gfx/angle and then
re-vendoring by copying the gfx/angle directory from the (firefox) upstream 140.12.0 ESR
firefox release (commit f802561).
See the individual commits.
Companion PR: servo/servo#46455