Skip to content

chore: fix spelling typos #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
childish-sambino merged 13 commits into from
Oct 14, 2020
Merged

chore: fix spelling typos #650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
791e339
Fix usage example syntax
jsoref Oct 14, 2020
7254cbb
spelling: attempted
jsoref Oct 14, 2020
577f2a8
spelling: authentication
jsoref Oct 14, 2020
391d523
spelling: disposition
jsoref Oct 14, 2020
64d664c
spelling: enforced
jsoref Oct 14, 2020
db8547a
spelling: grammar
jsoref Oct 14, 2020
5d6a08a
spelling: personalization
jsoref Oct 14, 2020
acbad18
spelling: representation
jsoref Oct 14, 2020
85163b6
spelling: response
jsoref Oct 14, 2020
0c96cd7
spelling: retrieve
jsoref Oct 14, 2020
b2700a5
spelling: smtpapi
jsoref Oct 14, 2020
1846f3d
spelling: tester
jsoref Oct 14, 2020
08d2900
Merge branch 'main' into spelling
Oct 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ All notable changes to this project will be documented in this file.
[2020-09-16] Version 4.6.5
--------------------------
**Library - Docs**
- [PR #477](https://github.com/sendgrid/sendgrid-java/pull/477): Run *.md documents through Grammer.ly. Thanks to [@vinird](https://github.com/vinird)!
- [PR #477](https://github.com/sendgrid/sendgrid-java/pull/477): Run *.md documents through Grammar.ly. Thanks to [@vinird](https://github.com/vinird)!

@jsoref jsoref Oct 14, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some irony here, since this is a .md file, and this change would have been flagged had it been run through grammar.ly.

@childish-sambino childish-sambino Oct 14, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lulz



[2020-08-19] Version 4.6.4
Expand Down
14 changes: 7 additions & 7 deletions FIRST_TIMERS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,13 +61,13 @@ Before creating a pull request, make sure that you respect the repository's cons
* [Node.js SDK](https://github.com/sendgrid/sendgrid-nodejs/issues?utf8=%E2%9C%93&q=is%3Aopen+label%3A%22difficulty%3A+easy%22+label%3A%22status%3A+help+wanted%22)
* [Java SDK](https://github.com/sendgrid/sendgrid-java/issues?utf8=%E2%9C%93&q=is%3Aopen+label%3A%22difficulty%3A+easy%22+label%3A%22status%3A+help+wanted%22)
* [Go SDK](https://github.com/sendgrid/sendgrid-go/issues?utf8=%E2%9C%93&q=is%3Aopen+label%3A%22difficulty%3A+easy%22+label%3A%22status%3A+help+wanted%22)
* [Python STMPAPI Client](https://github.com/sendgrid/smtpapi-python/issues?utf8=%E2%9C%93&q=is%3Aopen+label%3A%22difficulty%3A+easy%22+label%3A%22status%3A+help+wanted%22)
* [PHP STMPAPI Client](https://github.com/sendgrid/smtpapi-php/issues?utf8=%E2%9C%93&q=is%3Aopen+label%3A%22difficulty%3A+easy%22+label%3A%22status%3A+help+wanted%22)
* [C# STMPAPI Client](https://github.com/sendgrid/smtpapi-csharp/issues?utf8=%E2%9C%93&q=is%3Aopen+label%3A%22difficulty%3A+easy%22+label%3A%22status%3A+help+wanted%22)
* [Ruby STMPAPI Client](https://github.com/sendgrid/smtpapi-ruby/issues?utf8=%E2%9C%93&q=is%3Aopen+label%3A%22difficulty%3A+easy%22+label%3A%22status%3A+help+wanted%22)
* [Node.js STMPAPI Client](https://github.com/sendgrid/smtpapi-nodejs/issues?utf8=%E2%9C%93&q=is%3Aopen+label%3A%22difficulty%3A+easy%22+label%3A%22status%3A+help+wanted%22)
* [Java STMPAPI Client](https://github.com/sendgrid/smtpapi-java/issues?utf8=%E2%9C%93&q=is%3Aopen+label%3A%22difficulty%3A+easy%22+label%3A%22status%3A+help+wanted%22)
* [Go STMPAPI Client](https://github.com/sendgrid/smtpapi-go/issues?utf8=%E2%9C%93&q=is%3Aopen+label%3A%22difficulty%3A+easy%22+label%3A%22status%3A+help+wanted%22)
* [Python SMTPAPI Client](https://github.com/sendgrid/smtpapi-python/issues?utf8=%E2%9C%93&q=is%3Aopen+label%3A%22difficulty%3A+easy%22+label%3A%22status%3A+help+wanted%22)
Comment on lines -70 to +64

@jsoref jsoref Oct 14, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the bright side, this repository consistently uses copy+paste (this makes fixing much easier than if it didn't...)

* [PHP SMTPAPI Client](https://github.com/sendgrid/smtpapi-php/issues?utf8=%E2%9C%93&q=is%3Aopen+label%3A%22difficulty%3A+easy%22+label%3A%22status%3A+help+wanted%22)
* [C# SMTPAPI Client](https://github.com/sendgrid/smtpapi-csharp/issues?utf8=%E2%9C%93&q=is%3Aopen+label%3A%22difficulty%3A+easy%22+label%3A%22status%3A+help+wanted%22)
* [Ruby SMTPAPI Client](https://github.com/sendgrid/smtpapi-ruby/issues?utf8=%E2%9C%93&q=is%3Aopen+label%3A%22difficulty%3A+easy%22+label%3A%22status%3A+help+wanted%22)
* [Node.js SMTPAPI Client](https://github.com/sendgrid/smtpapi-nodejs/issues?utf8=%E2%9C%93&q=is%3Aopen+label%3A%22difficulty%3A+easy%22+label%3A%22status%3A+help+wanted%22)
* [Java SMTPAPI Client](https://github.com/sendgrid/smtpapi-java/issues?utf8=%E2%9C%93&q=is%3Aopen+label%3A%22difficulty%3A+easy%22+label%3A%22status%3A+help+wanted%22)
* [Go SMTPAPI Client](https://github.com/sendgrid/smtpapi-go/issues?utf8=%E2%9C%93&q=is%3Aopen+label%3A%22difficulty%3A+easy%22+label%3A%22status%3A+help+wanted%22)
* [Python HTTP Client](https://github.com/sendgrid/python-http-client/issues?utf8=%E2%9C%93&q=is%3Aopen+label%3A%22difficulty%3A+easy%22+label%3A%22status%3A+help+wanted%22)
* [PHP HTTP Client](https://github.com/sendgrid/php-http-client/issues?utf8=%E2%9C%93&q=is%3Aopen+label%3A%22difficulty%3A+easy%22+label%3A%22status%3A+help+wanted%22)
* [C# HTTP Client](https://github.com/sendgrid/csharp-http-client/issues?utf8=%E2%9C%93&q=is%3Aopen+label%3A%22difficulty%3A+easy%22+label%3A%22status%3A+help+wanted%22)
Expand Down
36 changes: 18 additions & 18 deletions USAGE.md
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion USE_CASES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ import java.io.IOException;
public class Example {
public static void main(String[] args) throws IOException {
Mail mail = new Mail();
mail.setFrom(new Email("teste@example.com"));
mail.setFrom(new Email("tester@example.com"));
mail.setTemplateId("d-2c214ac919e84170b21855cc129b4a5f");

Personalization personalization = new Personalization();
Expand Down
2 changes: 1 addition & 1 deletion examples/accesssettings/Example.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ protected Response execute(Request request) throws IOException {
return response;
}

protected void printResonseInfo(Response response) {
protected void printResponseInfo(Response response) {
System.out.println(response.getStatusCode());
System.out.println(response.getBody());
System.out.println(response.getHeaders());
Expand Down
2 changes: 1 addition & 1 deletion examples/ips/RetrieveAllPools.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
// GET /ips/pools


public class RetieveAllIPPools {
public class RetrieveAllIPPools {
public static void main(String[] args) throws IOException {
try {
SendGrid sg = new SendGrid(System.getenv("SENDGRID_API_KEY"));
Expand Down
0 examples/user/GetEnforedTLS.java → examples/user/GetEnforcedTLS.java
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion examples/user/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
- [Update Username](UpdateUsername.java)

## Security Settings Examples
- [Get Enforced TLS](GetEnforedTLS.java)
- [Get Enforced TLS](GetEnforcedTLS.java)

@jsoref jsoref Oct 14, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the file needs to be renamed. Oddly, the class in the file isn't named to match the file name in accordance to general Java naming conventions.

- [Update Enforced TLS](UpdateEnforcedTLS.java)

## Webhook Settings Examples
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/sendgrid/RateLimitException.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public Request getRequest() {
}

/**
* Get the number of times the action was attemted.
* Get the number of times the action was attempted.
*
* @return the retry count.
*/
Expand Down
6 changes: 3 additions & 3 deletions src/main/java/com/sendgrid/helpers/mail/Mail.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ public List<Personalization> getPersonalization() {
}

/**
* Add a personalizaton to the email.
* Add a personalization to the email.
*
* @param personalization a personalization.
*/
Expand Down Expand Up @@ -506,7 +506,7 @@ public void setReplyTo(Email replyTo) {
}

/**
* Create a string represenation of the Mail object JSON.
* Create a string representation of the Mail object JSON.
*
* @return a JSON string.
* @throws IOException in case of a JSON marshal error.
Expand All @@ -521,7 +521,7 @@ public String build() throws IOException {
}

/**
* Create a string represenation of the Mail object JSON and pretty print it.
* Create a string representation of the Mail object JSON and pretty print it.
*
* @return a pretty JSON string.
* @throws IOException in case of a JSON marshal error.
Expand Down
6 changes: 3 additions & 3 deletions src/test/java/com/sendgrid/helpers/AttachmentBuilderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,18 +18,18 @@ public void testCreateAttachments() {
String content = "This test checks if the builder works fine";
InputStream contentStream = new ByteArrayInputStream(content.getBytes(Charset.forName("UTF-8")));
String contentId = "someId";
String dispositon = "someDisposition";
String disposition = "someDisposition";

Attachments attachments = new Attachments.Builder(fileName, contentStream)
.withType(type)
.withContentId(contentId)
.withDisposition(dispositon)
.withDisposition(disposition)
.build();

Assert.assertEquals(attachments.getType(), type);
Assert.assertEquals(attachments.getFilename(), fileName);
Assert.assertEquals(attachments.getContentId(), contentId);
Assert.assertEquals(attachments.getDisposition(), dispositon);
Assert.assertEquals(attachments.getDisposition(), disposition);
Assert.assertEquals(attachments.getContent(), Base64.encodeBase64String(content.getBytes(Charset.forName("UTF-8"))));
}

Expand Down