chore: fix spelling typos - #650
Merged
Merged
Conversation
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
thinkingserious
added
the
status: code review request
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
jsoref
commented
Oct 14, 2020
| request.setMethod(Method.POST); | ||
| request.setEndpoint("asm/groups"); | ||
| request.setBody("{\"is_default\":true,\"description\":\"Suggestions for products our users might like.\",\"name\":\"Product) Suggestions\"}"; | ||
| request.setBody("{\"is_default\":true,\"description\":\"Suggestions for products our users might like.\",\"name\":\"Product) Suggestions\"}"); |
Contributor
Author
There was a problem hiding this comment.
This pattern is repeated throughout this file and unfortunately, it means that the examples here don't work / compile without this change.
I am not confirming that they work with this change, but, they would have a chance ...
| } | ||
| ``` | ||
| ## Remove an IP from a domain authenticaiton. | ||
| ## Remove an IP from a domain authentication. |
Contributor
Author
There was a problem hiding this comment.
Not every change in this file is a case of adding the ) to match a (.
|
|
||
| ## Security Settings Examples | ||
| - [Get Enforced TLS](GetEnforedTLS.java) | ||
| - [Get Enforced TLS](GetEnforcedTLS.java) |
Contributor
Author
There was a problem hiding this comment.
Yes, the file needs to be renamed. Oddly, the class in the file isn't named to match the file name in accordance to general Java naming conventions.
Comment on lines
-70
to
+64
| * [Go STMPAPI Client](https://github.com/sendgrid/smtpapi-go/issues?utf8=%E2%9C%93&q=is%3Aopen+label%3A%22difficulty%3A+easy%22+label%3A%22status%3A+help+wanted%22) | ||
| * [Python SMTPAPI Client](https://github.com/sendgrid/smtpapi-python/issues?utf8=%E2%9C%93&q=is%3Aopen+label%3A%22difficulty%3A+easy%22+label%3A%22status%3A+help+wanted%22) |
Contributor
Author
There was a problem hiding this comment.
On the bright side, this repository consistently uses copy+paste (this makes fixing much easier than if it didn't...)
| -------------------------- | ||
| **Library - Docs** | ||
| - [PR #477](https://github.com/sendgrid/sendgrid-java/pull/477): Run *.md documents through Grammer.ly. Thanks to [@vinird](https://github.com/vinird)! | ||
| - [PR #477](https://github.com/sendgrid/sendgrid-java/pull/477): Run *.md documents through Grammar.ly. Thanks to [@vinird](https://github.com/vinird)! |
Contributor
Author
There was a problem hiding this comment.
There's some irony here, since this is a .md file, and this change would have been flagged had it been run through grammar.ly.
Contributor
Author
|
I'm happy to rewrite the commits or squash them as requested. |
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
childish-sambino
approved these changes
Oct 14, 2020
| -------------------------- | ||
| **Library - Docs** | ||
| - [PR #477](https://github.com/sendgrid/sendgrid-java/pull/477): Run *.md documents through Grammer.ly. Thanks to [@vinird](https://github.com/vinird)! | ||
| - [PR #477](https://github.com/sendgrid/sendgrid-java/pull/477): Run *.md documents through Grammar.ly. Thanks to [@vinird](https://github.com/vinird)! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
This PR corrects misspellings identified by the check-spelling action.
The misspellings have been reported at jsoref@7a7f4d9#commitcomment-43247897
The action reports that the changes in this PR would make it happy: jsoref@29041f2
Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.
Additionally, this PR fixes a number of examples in the
USAGE.mdfile.Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.