Skip to content

std: use UNIX's Instant and SystemTime on Hermit - #161297

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
joboet:hermit_time_reuse
Aug 19, 2026
Merged

std: use UNIX's Instant and SystemTime on Hermit#161297
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
joboet:hermit_time_reuse

Conversation

@joboet

@joboet joboet commented Aug 18, 2026

Copy link
Copy Markdown
Member

Since #154234 already shares UNIX's internal Timespec abstraction, Instant and SystemTime are just very thin wrappers over that. This shouldn't change any behaviour.

CC @stepancheg
CC @stlankes @mkroening

@joboet joboet added the O-hermit Operating System: Hermit label Aug 18, 2026
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 18, 2026
@rustbot

rustbot commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

r? @nia-e

rustbot has assigned @nia-e.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ChrisDenton, libs
  • @ChrisDenton, libs expanded to 13 candidates
  • Random selection from ChrisDenton, JohnTitor, Mark-Simulacrum, clarfonthey, nia-e

@nia-e

nia-e commented Aug 18, 2026

Copy link
Copy Markdown
Member

@bors r+

@rust-bors

rust-bors Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 0c0be1f has been approved by nia-e

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 18, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Aug 19, 2026
std: use UNIX's `Instant` and `SystemTime` on Hermit

Since rust-lang#154234 already shares UNIX's internal `Timespec` abstraction, `Instant` and `SystemTime` are just very thin wrappers over that. This shouldn't change any behaviour.

CC @stepancheg
CC @stlankes @mkroening
rust-bors Bot pushed a commit that referenced this pull request Aug 19, 2026
Rollup of 18 pull requests

Successful merges:

 - #154210 (fix: fix the capture behavior of `if let` in closures)
 - #156176 (Initial implementation of `FnPtr` trait)
 - #160767 (Unify E0117 foreign-trait label for ADT/primitive types with existing Slice/Array/Tuple handling)
 - #161297 (std: use UNIX's `Instant` and `SystemTime` on Hermit)
 - #160489 (Adding diagnostic item markers for multiple fs functions and structs)
 - #160643 (Require windowed (and exception) for Xtensa ABI)
 - #161088 (suppress projection errors already covered by a trait error)
 - #161114 (Remove fields from TypeKind: Struct, Enum, Union and Tuple)
 - #161115 (Assorted allocator nitpicks)
 - #161220 (bootstrap: Allow `./x fix --allow-dirty`)
 - #161296 (Enable overflow checks in `rustc_thread_pool`)
 - #161298 (remove rustc_error_messages dependency)
 - #161304 (Rename test so it matches the issue)
 - #161309 (`allow(non_camel_case_types)` in `minicore.rs`)
 - #161315 (Relax codgen test variable regex)
 - #161318 (Doc: clarify how `Read::bytes` handling Interrupted errors)
 - #161321 (Update books)
 - #161335 ([compiletest] Use the correct rustc lib directory for query_rustc_output)
@rust-bors
rust-bors Bot merged commit ab04ce1 into rust-lang:main Aug 19, 2026
13 checks passed
@rustbot rustbot added this to the 1.100.0 milestone Aug 19, 2026
rust-bors Bot pushed a commit that referenced this pull request Aug 19, 2026
Rollup merge of #161297 - joboet:hermit_time_reuse, r=nia-e

std: use UNIX's `Instant` and `SystemTime` on Hermit

Since #154234 already shares UNIX's internal `Timespec` abstraction, `Instant` and `SystemTime` are just very thin wrappers over that. This shouldn't change any behaviour.

CC @stepancheg
CC @stlankes @mkroening
RalfJung pushed a commit to RalfJung/miri that referenced this pull request Aug 19, 2026
Rollup of 18 pull requests

Successful merges:

 - rust-lang/rust#154210 (fix: fix the capture behavior of `if let` in closures)
 - rust-lang/rust#156176 (Initial implementation of `FnPtr` trait)
 - rust-lang/rust#160767 (Unify E0117 foreign-trait label for ADT/primitive types with existing Slice/Array/Tuple handling)
 - rust-lang/rust#161297 (std: use UNIX's `Instant` and `SystemTime` on Hermit)
 - rust-lang/rust#160489 (Adding diagnostic item markers for multiple fs functions and structs)
 - rust-lang/rust#160643 (Require windowed (and exception) for Xtensa ABI)
 - rust-lang/rust#161088 (suppress projection errors already covered by a trait error)
 - rust-lang/rust#161114 (Remove fields from TypeKind: Struct, Enum, Union and Tuple)
 - rust-lang/rust#161115 (Assorted allocator nitpicks)
 - rust-lang/rust#161220 (bootstrap: Allow `./x fix --allow-dirty`)
 - rust-lang/rust#161296 (Enable overflow checks in `rustc_thread_pool`)
 - rust-lang/rust#161298 (remove rustc_error_messages dependency)
 - rust-lang/rust#161304 (Rename test so it matches the issue)
 - rust-lang/rust#161309 (`allow(non_camel_case_types)` in `minicore.rs`)
 - rust-lang/rust#161315 (Relax codgen test variable regex)
 - rust-lang/rust#161318 (Doc: clarify how `Read::bytes` handling Interrupted errors)
 - rust-lang/rust#161321 (Update books)
 - rust-lang/rust#161335 ([compiletest] Use the correct rustc lib directory for query_rustc_output)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

O-hermit Operating System: Hermit S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants