Unify E0117 foreign-trait label for ADT/primitive types with existing Slice/Array/Tuple handling by Omar1H1 · Pull Request #160767 · rust-lang/rust

Omar1H1 · 2026-08-08T16:37:36Z

What this does

emit_orphan_check_error (in compiler/rustc_hir_analysis/src/coherence/orphan.rs) already has an is_foreign flag, true whenever a non-local type sits in one of the trait's own parameter positions rather than Self. The Slice, Array, and Tuple arms already use it to switch their label to a generic "this is not defined in the current crate because this is a foreign trait" message instead of naming the type. The Adt arm and the catch-all _ arm (covering primitives) never checked is_foreign and always named the type, even in the same non-Self position.

This PR extends the same is_foreign branch to those two arms, so all four are consistent. No new types or subdiagnostics reuses the existing OnlyCurrentTraitsForeign struct already used a few lines above.

LLM use :
I used LLM to explore the project and find where code that tags labels

Before / after

impl PartialEq for u32 {
    fn eq(&self, _other: &Self) -> bool { todo!() }
}

Before :

   |      |             `u32` is not defined in the current crate
   |      `u32` is not defined in the current crate

After :

   |      |       `u32` is not defined in the current crate
   |      this is not defined in the current crate because this is a foreign trait

Addresses #160648

r? compiler

[] I did not use an LLM to create a change in this PR.
I used an LLM to create a change in this PR, and I have explained below how it was used.

… orphan check `emit_orphan_check_error` already special-cases non-local types that appear in a foreign trait's own parameter position (as opposed to Self): for Slice, Array, and Tuple, the label reads "this is not defined in the current crate because this is a foreign trait" instead of naming the type. The Adt arm and the primitive/catch-all arm never checked this and always named the type instead, even in the same non-Self position. This produced a confusing diagnostic for impls like impl PartialEq for u32 {} where Rhs defaults to Self (u32), so both the Self label and the Rhs label read `u32` is not defined in the current crate, with the second one visually landing under PartialEq since the defaulted Rhs has no span of its own. Extend the existing is_foreign check to the Adt and catch-all arms so all four cases behave consistently. Addresses rust-lang#160648

rustbot · 2026-08-08T16:37:41Z

Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @petrochenkov (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

@rustbot author: the review is finished, PR author should check the comments and take action accordingly
@rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

Why was this reviewer chosen?

The reviewer was selected based on:

compiler expanded to 75 candidates
Random selection from 19 candidates

rustbot · 2026-08-08T16:37:42Z

⚠️ Warning ⚠️

There are issue links (such as #123) in the commit messages of the following commits.
Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.
- e6b20c8

petrochenkov · 2026-08-18T11:41:35Z

@bors r+

rust-bors · 2026-08-18T11:41:38Z

📌 Commit e6b20c8 has been approved by petrochenkov

It is now in the queue for this repository.

…x, r=petrochenkov Unify E0117 foreign-trait label for ADT/primitive types with existing Slice/Array/Tuple handling ### What this does `emit_orphan_check_error` (in `compiler/rustc_hir_analysis/src/coherence/orphan.rs`) already has an `is_foreign` flag, true whenever a non-local type sits in one of the *trait's own* parameter positions rather than `Self`. The `Slice`, `Array`, and `Tuple` arms already use it to switch their label to a generic "this is not defined in the current crate because this is a foreign trait" message instead of naming the type. The `Adt` arm and the catch-all `_` arm (covering primitives) never checked `is_foreign` and always named the type, even in the same non-Self position. This PR extends the same `is_foreign` branch to those two arms, so all four are consistent. No new types or subdiagnostics reuses the existing `OnlyCurrentTraitsForeign` struct already used a few lines above. LLM use : I used LLM to explore the project and find where code that tags labels ### Before / after ```rust impl PartialEq for u32 { fn eq(&self, _other: &Self) -> bool { todo!() } } ``` Before : ```Plaintext | | `u32` is not defined in the current crate | `u32` is not defined in the current crate ``` After : ```Plaintext | | `u32` is not defined in the current crate | this is not defined in the current crate because this is a foreign trait ``` Addresses rust-lang#160648 r? compiler

…uwer Rollup of 8 pull requests Successful merges: - #154210 (fix: fix the capture behavior of `if let` in closures) - #156176 (Initial implementation of `FnPtr` trait) - #160767 (Unify E0117 foreign-trait label for ADT/primitive types with existing Slice/Array/Tuple handling) - #160489 (Adding diagnostic item markers for multiple fs functions and structs) - #161220 (bootstrap: Allow `./x fix --allow-dirty`) - #161291 (Rename `ProjectionPredicate` and `TraitPredicate`) - #161296 (Enable overflow checks in `rustc_thread_pool`) - #161304 (Rename test so it matches the issue)

…x, r=petrochenkov Unify E0117 foreign-trait label for ADT/primitive types with existing Slice/Array/Tuple handling ### What this does `emit_orphan_check_error` (in `compiler/rustc_hir_analysis/src/coherence/orphan.rs`) already has an `is_foreign` flag, true whenever a non-local type sits in one of the *trait's own* parameter positions rather than `Self`. The `Slice`, `Array`, and `Tuple` arms already use it to switch their label to a generic "this is not defined in the current crate because this is a foreign trait" message instead of naming the type. The `Adt` arm and the catch-all `_` arm (covering primitives) never checked `is_foreign` and always named the type, even in the same non-Self position. This PR extends the same `is_foreign` branch to those two arms, so all four are consistent. No new types or subdiagnostics reuses the existing `OnlyCurrentTraitsForeign` struct already used a few lines above. LLM use : I used LLM to explore the project and find where code that tags labels ### Before / after ```rust impl PartialEq for u32 { fn eq(&self, _other: &Self) -> bool { todo!() } } ``` Before : ```Plaintext | | `u32` is not defined in the current crate | `u32` is not defined in the current crate ``` After : ```Plaintext | | `u32` is not defined in the current crate | this is not defined in the current crate because this is a foreign trait ``` Addresses rust-lang#160648 r? compiler

Rollup of 18 pull requests Successful merges: - #154210 (fix: fix the capture behavior of `if let` in closures) - #156176 (Initial implementation of `FnPtr` trait) - #160767 (Unify E0117 foreign-trait label for ADT/primitive types with existing Slice/Array/Tuple handling) - #161297 (std: use UNIX's `Instant` and `SystemTime` on Hermit) - #160489 (Adding diagnostic item markers for multiple fs functions and structs) - #160643 (Require windowed (and exception) for Xtensa ABI) - #161088 (suppress projection errors already covered by a trait error) - #161114 (Remove fields from TypeKind: Struct, Enum, Union and Tuple) - #161115 (Assorted allocator nitpicks) - #161220 (bootstrap: Allow `./x fix --allow-dirty`) - #161296 (Enable overflow checks in `rustc_thread_pool`) - #161298 (remove rustc_error_messages dependency) - #161304 (Rename test so it matches the issue) - #161309 (`allow(non_camel_case_types)` in `minicore.rs`) - #161315 (Relax codgen test variable regex) - #161318 (Doc: clarify how `Read::bytes` handling Interrupted errors) - #161321 (Update books) - #161335 ([compiletest] Use the correct rustc lib directory for query_rustc_output)

Rollup merge of #160767 - Omar1H1:diagnostics/e0117-label-fix, r=petrochenkov Unify E0117 foreign-trait label for ADT/primitive types with existing Slice/Array/Tuple handling ### What this does `emit_orphan_check_error` (in `compiler/rustc_hir_analysis/src/coherence/orphan.rs`) already has an `is_foreign` flag, true whenever a non-local type sits in one of the *trait's own* parameter positions rather than `Self`. The `Slice`, `Array`, and `Tuple` arms already use it to switch their label to a generic "this is not defined in the current crate because this is a foreign trait" message instead of naming the type. The `Adt` arm and the catch-all `_` arm (covering primitives) never checked `is_foreign` and always named the type, even in the same non-Self position. This PR extends the same `is_foreign` branch to those two arms, so all four are consistent. No new types or subdiagnostics reuses the existing `OnlyCurrentTraitsForeign` struct already used a few lines above. LLM use : I used LLM to explore the project and find where code that tags labels ### Before / after ```rust impl PartialEq for u32 { fn eq(&self, _other: &Self) -> bool { todo!() } } ``` Before : ```Plaintext | | `u32` is not defined in the current crate | `u32` is not defined in the current crate ``` After : ```Plaintext | | `u32` is not defined in the current crate | this is not defined in the current crate because this is a foreign trait ``` Addresses #160648 r? compiler

Rollup of 18 pull requests Successful merges: - rust-lang/rust#154210 (fix: fix the capture behavior of `if let` in closures) - rust-lang/rust#156176 (Initial implementation of `FnPtr` trait) - rust-lang/rust#160767 (Unify E0117 foreign-trait label for ADT/primitive types with existing Slice/Array/Tuple handling) - rust-lang/rust#161297 (std: use UNIX's `Instant` and `SystemTime` on Hermit) - rust-lang/rust#160489 (Adding diagnostic item markers for multiple fs functions and structs) - rust-lang/rust#160643 (Require windowed (and exception) for Xtensa ABI) - rust-lang/rust#161088 (suppress projection errors already covered by a trait error) - rust-lang/rust#161114 (Remove fields from TypeKind: Struct, Enum, Union and Tuple) - rust-lang/rust#161115 (Assorted allocator nitpicks) - rust-lang/rust#161220 (bootstrap: Allow `./x fix --allow-dirty`) - rust-lang/rust#161296 (Enable overflow checks in `rustc_thread_pool`) - rust-lang/rust#161298 (remove rustc_error_messages dependency) - rust-lang/rust#161304 (Rename test so it matches the issue) - rust-lang/rust#161309 (`allow(non_camel_case_types)` in `minicore.rs`) - rust-lang/rust#161315 (Relax codgen test variable regex) - rust-lang/rust#161318 (Doc: clarify how `Read::bytes` handling Interrupted errors) - rust-lang/rust#161321 (Update books) - rust-lang/rust#161335 ([compiletest] Use the correct rustc lib directory for query_rustc_output)

rustbot assigned petrochenkov Aug 8, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 8, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 18, 2026

JonathanBrouwer mentioned this pull request Aug 18, 2026

Rollup of 8 pull requests #161311

Closed

JonathanBrouwer mentioned this pull request Aug 18, 2026

Rollup of 13 pull requests #161322

Closed

This was referenced Aug 19, 2026

Rollup of 19 pull requests #161337

Closed

Rollup of 18 pull requests #161338

Merged

rust-bors Bot merged commit bab437e into rust-lang:main Aug 19, 2026
13 checks passed

rustbot added this to the 1.100.0 milestone Aug 19, 2026

Navigation Menu

Uh oh!

Uh oh!

Unify E0117 foreign-trait label for ADT/primitive types with existing Slice/Array/Tuple handling - #160767

Unify E0117 foreign-trait label for ADT/primitive types with existing Slice/Array/Tuple handling#160767
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Omar1H1:diagnostics/e0117-label-fix

Omar1H1 commented Aug 8, 2026 •

edited by steffahn

Loading

Uh oh!

rustbot commented Aug 8, 2026

Uh oh!

rustbot commented Aug 8, 2026

Uh oh!

petrochenkov commented Aug 18, 2026

Uh oh!

rust-bors Bot commented Aug 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

Omar1H1 commented Aug 8, 2026 • edited by steffahn Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this does

Before / after

Uh oh!

rustbot commented Aug 8, 2026

Uh oh!

rustbot commented Aug 8, 2026

Uh oh!

petrochenkov commented Aug 18, 2026

Uh oh!

rust-bors Bot commented Aug 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Omar1H1 commented Aug 8, 2026 •

edited by steffahn

Loading