Add regression test for assoc const panic ICE in match - #160858
Merged
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use Why was this reviewer chosen?The reviewer was selected based on:
|
qaijuang
suggested changes
Aug 10, 2026
Comment on lines
+1
to
+6
| //! Regression test for <https://github.com/rust-lang/rust/issues/91514>. | ||
| //! | ||
| //! An associated const initialized with `panic!()`, referenced from a `match` arm | ||
| //! with arms on both sides, used to ICE during codegen. It now fails const-eval | ||
| //! cleanly instead. The failure only surfaces on a full build (not `check`), since | ||
| //! the const is evaluated during codegen. |
Contributor
There was a problem hiding this comment.
Can we use plain comment ?
Suggested change
| //! Regression test for <https://github.com/rust-lang/rust/issues/91514>. | |
| //! | |
| //! An associated const initialized with `panic!()`, referenced from a `match` arm | |
| //! with arms on both sides, used to ICE during codegen. It now fails const-eval | |
| //! cleanly instead. The failure only surfaces on a full build (not `check`), since | |
| //! the const is evaluated during codegen. | |
| // Regression test for <https://github.com/rust-lang/rust/issues/91514>. | |
| // | |
| // An associated const initialized with `panic!()`, referenced from a `match` arm | |
| // with arms on both sides, used to ICE during codegen. It now fails const-eval | |
| // cleanly instead. The failure only surfaces on a full build (not `check`), since | |
| // the const is evaluated during codegen. |
zakrad
force-pushed
the
regr-test-91514
branch
from
August 10, 2026 16:24
4d5aebd to
aed6c87
Compare
JohnTitor
approved these changes
Aug 10, 2026
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 11, 2026
…uwer Rollup of 7 pull requests Successful merges: - #160629 ([Priroda] Add bootstrap test and check steps) - #160811 (Fix `visible_parent_map` fallback map merging perf regression) - #154329 (Diagnostics ICE when replaying proof trees with next-solver) - #157841 (Ensure inferred let pattern types are well-formed) - #159300 (Implement `to_string()` on `ByteStr` and `ByteString`) - #160858 (Add regression test for assoc const panic ICE in match) - #160864 (Rename `HostEffectPredicate` to `HostEffectClause`)
github-actions Bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Aug 11, 2026
…uwer Rollup of 7 pull requests Successful merges: - rust-lang/rust#160629 ([Priroda] Add bootstrap test and check steps) - rust-lang/rust#160811 (Fix `visible_parent_map` fallback map merging perf regression) - rust-lang/rust#154329 (Diagnostics ICE when replaying proof trees with next-solver) - rust-lang/rust#157841 (Ensure inferred let pattern types are well-formed) - rust-lang/rust#159300 (Implement `to_string()` on `ByteStr` and `ByteString`) - rust-lang/rust#160858 (Add regression test for assoc const panic ICE in match) - rust-lang/rust#160864 (Rename `HostEffectPredicate` to `HostEffectClause`)
bjorn3
pushed a commit
to bjorn3/stdarch
that referenced
this pull request
Aug 13, 2026
…uwer Rollup of 7 pull requests Successful merges: - rust-lang/rust#160629 ([Priroda] Add bootstrap test and check steps) - rust-lang/rust#160811 (Fix `visible_parent_map` fallback map merging perf regression) - rust-lang/rust#154329 (Diagnostics ICE when replaying proof trees with next-solver) - rust-lang/rust#157841 (Ensure inferred let pattern types are well-formed) - rust-lang/rust#159300 (Implement `to_string()` on `ByteStr` and `ByteString`) - rust-lang/rust#160858 (Add regression test for assoc const panic ICE in match) - rust-lang/rust#160864 (Rename `HostEffectPredicate` to `HostEffectClause`)
pull Bot
pushed a commit
to LeeeeeeM/miri
that referenced
this pull request
Aug 16, 2026
…uwer Rollup of 7 pull requests Successful merges: - rust-lang/rust#160629 ([Priroda] Add bootstrap test and check steps) - rust-lang/rust#160811 (Fix `visible_parent_map` fallback map merging perf regression) - rust-lang/rust#154329 (Diagnostics ICE when replaying proof trees with next-solver) - rust-lang/rust#157841 (Ensure inferred let pattern types are well-formed) - rust-lang/rust#159300 (Implement `to_string()` on `ByteStr` and `ByteString`) - rust-lang/rust#160858 (Add regression test for assoc const panic ICE in match) - rust-lang/rust#160864 (Rename `HostEffectPredicate` to `HostEffectClause`)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #91514, The associated const panic!() in a match used to ICE and now fails const eval cleanly