[Priroda] Add bootstrap test and check steps by moabo3li · Pull Request #160629 · rust-lang/rust

moabo3li · 2026-08-06T10:53:26Z

The priroda crate lives under src/tools/miri/priroda and shares miri's sysroot and toolchain setup, so register a test step that mirrors the existing miri one and a check step alongside cargo-miri.

r? oli-obk

rustbot · 2026-08-06T11:13:46Z

miri is developed in its own repository. If the Miri part of this change can be broken out, consider making this change to rust-lang/miri instead. However, if Miri needs adjusting for rustc changes, just ignore this message.

cc @rust-lang/miri

oli-obk · 2026-08-06T11:15:22Z

Does the [workspace] change affect building priroda (or miri) inside the miri repo?

moabo3li · 2026-08-06T11:17:47Z

Does the [workspace] change affect building priroda (or miri) inside the miri repo?

No, it doesn't break it.

oli-obk · 2026-08-06T11:20:53Z

@bors r+ rollup=iffy

rust-bors · 2026-08-06T11:20:55Z

📌 Commit baf696d has been approved by oli-obk

It is now in the queue for this repository.

moabo3li · 2026-08-06T11:25:02Z

I think it failed because the last PR hasn’t landed yet.

rustbot · 2026-08-06T12:03:12Z

Warning

If you are changing how CI LLVM is built or linked, make sure to bump
src/bootstrap/download-ci-llvm-stamp.

cc @jieyouxu

rust-bors · 2026-08-06T12:03:13Z

⚠️ A new commit 2a9baea5bc1794c5edc9dc1d8bd55127d37bcd07 was pushed.

This pull request was unapproved.

Kobzol

Thanks!

View changes since this review

RalfJung · 2026-08-06T12:36:10Z

The build here apparently runs with deny(warnings). Does Miri's CI for Priroda also have deny(warnings)?

Also, once this lands, please remember to add Priroda to the bootstrap build in Miri's CI to ensure it builds with the bootstrap compiler (and not just with the nightly compiler).

I think it failed because the last PR hasn’t landed yet.

I made a sync PR: #160634

RalfJung · 2026-08-06T12:41:14Z

In particular, this one here...

  warning: hidden lifetime parameters in types are deprecated
      --> src/tools/miri/priroda/src/main.rs:1029:40
       |
  1029 |     fn print_location(&self, session: &PrirodaContext) {
       |                                        ^^^^^^^^^^^^^^ expected lifetime parameter
       |
       = note: `-W elided-lifetimes-in-paths` implied by `-W rust-2018-idioms`
       = help: to override `-W rust-2018-idioms` add `#[allow(elided_lifetimes_in_paths)]`

probably currently does not get caught? I assume bootstrap is adding -W rust-2018-idioms ? Miri's own CI doesn't so we are risking mismatches. Miri itself has the following:

#![warn(
    rust_2018_idioms,
    unqualified_local_imports,
)]

Probably would be good to also add that to Priroda. (Can also be done in a cargo section these days if you prefer that.)

rustbot · 2026-08-08T20:22:30Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

moabo3li · 2026-08-08T20:33:50Z

In particular, this one here...
  warning: hidden lifetime parameters in types are deprecated
      --> src/tools/miri/priroda/src/main.rs:1029:40
       |
  1029 |     fn print_location(&self, session: &PrirodaContext) {
       |                                        ^^^^^^^^^^^^^^ expected lifetime parameter
       |
       = note: `-W elided-lifetimes-in-paths` implied by `-W rust-2018-idioms`
       = help: to override `-W rust-2018-idioms` add `#[allow(elided_lifetimes_in_paths)]`
probably currently does not get caught? I assume bootstrap is adding -W rust-2018-idioms ? Miri's own CI doesn't so we are risking mismatches. Miri itself has the following:
#![warn(
    rust_2018_idioms,
    unqualified_local_imports,
)]
Probably would be good to also add that to Priroda. (Can also be done in a cargo section these days if you prefer that.)

Thanks for the heads-up!

yep, added the lints and bootstrap check, should be covered now.

RalfJung · 2026-08-08T20:42:27Z

          ./x check miri
+          ./x check src/tools/miri/priroda


Suggested change

./x check miri

./x check src/tools/miri/priroda

# checks every tool in that folder (including priroda)

./x check src/tools/miri

View changes since the review

- Add rust_2018_idioms warn in Cargo.toml to catch elided lifetimes and other 2018-idiom lints, matching Miri crate-level lint policy. - Add ./x check src/tools/miri/priroda to bootstrap CI step. - Add cargo clippy --all-targets --locked -- -D warnings step to priroda CI job.

oli-obk

@bors r+

View changes since this review

rust-bors · 2026-08-10T19:04:21Z

📌 Commit e2a6442 has been approved by oli-obk

It is now in the queue for this repository.

…uwer Rollup of 7 pull requests Successful merges: - #160629 ([Priroda] Add bootstrap test and check steps) - #160811 (Fix `visible_parent_map` fallback map merging perf regression) - #154329 (Diagnostics ICE when replaying proof trees with next-solver) - #157841 (Ensure inferred let pattern types are well-formed) - #159300 (Implement `to_string()` on `ByteStr` and `ByteString`) - #160858 (Add regression test for assoc const panic ICE in match) - #160864 (Rename `HostEffectPredicate` to `HostEffectClause`)

Rollup merge of #160629 - moabo3li:priroda-bootstrap-ci, r=oli-obk [Priroda] Add bootstrap test and check steps The priroda crate lives under src/tools/miri/priroda and shares miri's sysroot and toolchain setup, so register a test step that mirrors the existing miri one and a check step alongside cargo-miri. r? oli-obk

…uwer Rollup of 7 pull requests Successful merges: - rust-lang/rust#160629 ([Priroda] Add bootstrap test and check steps) - rust-lang/rust#160811 (Fix `visible_parent_map` fallback map merging perf regression) - rust-lang/rust#154329 (Diagnostics ICE when replaying proof trees with next-solver) - rust-lang/rust#157841 (Ensure inferred let pattern types are well-formed) - rust-lang/rust#159300 (Implement `to_string()` on `ByteStr` and `ByteString`) - rust-lang/rust#160858 (Add regression test for assoc const panic ICE in match) - rust-lang/rust#160864 (Rename `HostEffectPredicate` to `HostEffectClause`)

rustbot assigned oli-obk Aug 6, 2026

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Aug 6, 2026

This comment has been minimized.

Sign in to view

moabo3li force-pushed the priroda-bootstrap-ci branch from 678ced9 to cfef2d4 Compare August 6, 2026 11:02

oli-obk approved these changes Aug 6, 2026

View reviewed changes

moabo3li force-pushed the priroda-bootstrap-ci branch from cfef2d4 to baf696d Compare August 6, 2026 11:13

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 6, 2026

This comment has been minimized.

Sign in to view

Kobzol reviewed Aug 6, 2026

View reviewed changes

Comment thread src/bootstrap/src/core/build_steps/test.rs

Comment thread src/bootstrap/src/core/build_steps/test.rs Outdated

moabo3li force-pushed the priroda-bootstrap-ci branch from baf696d to 2a9baea Compare August 6, 2026 12:03

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 6, 2026

rustbot added A-CI Area: Our Github Actions CI T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Aug 6, 2026

This comment has been minimized.

Sign in to view

moabo3li force-pushed the priroda-bootstrap-ci branch from 2a9baea to cb36e40 Compare August 6, 2026 12:15

This comment has been minimized.

Sign in to view

Kobzol approved these changes Aug 6, 2026

View reviewed changes

[Priroda] Add bootstrap test and check steps

a529dee

moabo3li force-pushed the priroda-bootstrap-ci branch from cb36e40 to 58b5196 Compare August 8, 2026 20:22

moabo3li force-pushed the priroda-bootstrap-ci branch 2 times, most recently from decbc23 to 7670508 Compare August 8, 2026 20:23

RalfJung reviewed Aug 8, 2026

View reviewed changes

moabo3li force-pushed the priroda-bootstrap-ci branch from 7670508 to e2a6442 Compare August 8, 2026 20:50

moabo3li requested a review from oli-obk August 10, 2026 05:45

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 10, 2026

oli-obk approved these changes Aug 10, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 10, 2026

JonathanBrouwer mentioned this pull request Aug 10, 2026

Rollup of 7 pull requests #160879

Merged

rust-bors Bot merged commit e84bdbd into rust-lang:main Aug 11, 2026
13 checks passed

rustbot added this to the 1.99.0 milestone Aug 11, 2026

Uh oh!

Uh oh!

Conversation

moabo3li commented Aug 6, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

rustbot commented Aug 6, 2026

Uh oh!

oli-obk commented Aug 6, 2026

Uh oh!

moabo3li commented Aug 6, 2026

Uh oh!

oli-obk commented Aug 6, 2026

Uh oh!

rust-bors Bot commented Aug 6, 2026

Uh oh!

moabo3li commented Aug 6, 2026

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

rustbot commented Aug 6, 2026

Uh oh!

rust-bors Bot commented Aug 6, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

Kobzol left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RalfJung commented Aug 6, 2026

Uh oh!

RalfJung commented Aug 6, 2026

Uh oh!

rustbot commented Aug 8, 2026

Uh oh!

moabo3li commented Aug 8, 2026

Uh oh!

RalfJung Aug 8, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

moabo3li Aug 8, 2026

Choose a reason for hiding this comment

Uh oh!

oli-obk left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors Bot commented Aug 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

moabo3li commented Aug 6, 2026 •

edited by rustbot

Loading

Kobzol left a comment •

edited by rustbot

Loading

RalfJung Aug 8, 2026 •

edited by rustbot

Loading

oli-obk left a comment •

edited by rustbot

Loading