Add missing <stdbool.h> include to time.h

[banerjs-overland]

rmw/include/rmw/time.h uses bool as the return type of rmw_time_equal() (line 60) but does not include <stdbool.h>. This previously worked because rcutils/time.h transitively pulled in <stdbool.h> via rcutils/types.h → hash_map.h → allocator.h.

After ros2/rcutils#580 (commit 47a44cb, backported to jazzy as #583) narrowed the include in rcutils/time.h from rcutils/types.h to rcutils/types/rcutils_ret.h, this transitive chain is broken. Any C translation unit that includes rmw/time.h now fails to compile:

  rmw/include/rmw/time.h:60:1: error: unknown type name 'bool'
     60 | bool
        | ^~~~

The fix is to add #include <stdbool.h> to rmw/time.h.

Verification

  /* C translation unit that includes rmw/time.h */
  #include "rmw/time.h"

  void test_func(void) {
      rmw_time_t a = {0, 0};
      rmw_time_t b = {0, 0};
      bool result = rmw_time_equal(a, b);
      (void)result;
  }

• Create a minimal colcon workspace with rcutils:jazzy and rmw:jazzy (unfixed) and the above C file in a test C package
• colcon build in the workspace reproduced the above error
• Changing the rmw package to include the fix in this MR allowed the build to succeed.

Did you use Generative AI?

Claude Opus 4.6

[mergify]

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

• Queue this pull request

[banerjs-overland]

Apologies, it looks like I have a lot of unintended commits along for the ride. Fixing. EDIT: Should be fixed now. It was a problem of selecting the wrong base branch

[banerjs-overland]

@wjwwood @ivanpauno Apologies for the direct ping, but any chance one of you may be able to review this PR and provide feedback (I could not figure out a handle for Brandon Ong)? Tagging both of you as documented maintainers of the package. Happy to provide more details or documentation, as necessary.

[fujitatomoya]

the fix itself looks good, but we should probably put this into rolling branch and backport downstream branches including jazzy?

[banerjs-overland]

@fujitatomoya Thank you for the review! I have reset my branch to rolling and cherry-picked the fix on top of it. Please take a look again when you are able.

[impala454]

Hi can you please backport to humble as well.

[mjcarroll]

@banerjs-overland do you think you can sign off the commit so that the DCO checker will pass?

[banerjs-overland]

@banerjs-overland do you think you can sign off the commit so that the DCO checker will pass?

@mjcarroll I have signed off on the commit. Unfortunately the DCO check is failing on commits further back in the history of this branch

[mjcarroll]

• Linux
• Linux-aarch64
• Linux-rhel
• Windows

[mjcarroll]

@Mergifyio backport lyrical kilted jazzy humble

[mergify]

backport lyrical kilted jazzy humble

✅ Backports have been created

Details

• #425 Add missing <stdbool.h> include to time.h (backport #423) has been created for branch lyrical
• #426 Add missing <stdbool.h> include to time.h (backport #423) has been created for branch kilted
• #427 Add missing <stdbool.h> include to time.h (backport #423) has been created for branch jazzy
• #428 Add missing <stdbool.h> include to time.h (backport #423) has been created for branch humble