Added missing headers - #580
Merged
Merged
Conversation
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
|
Tick the box to add this pull request to the merge queue (same as
|
Contributor
Author
|
Pulls: #580
|
asymingt
approved these changes
Jul 30, 2026
Contributor
Author
|
@Mergifyio backport lyrical kilted jazzy humble |
✅ Backports have been createdDetails
|
This was referenced Jul 30, 2026
ahcorde
added a commit
that referenced
this pull request
Jul 31, 2026
ahcorde
added a commit
that referenced
this pull request
Jul 31, 2026
ahcorde
added a commit
that referenced
this pull request
Jul 31, 2026
ahcorde
added a commit
that referenced
this pull request
Jul 31, 2026
banerjs-overland
added a commit
to banerjs-overland/rmw
that referenced
this pull request
Aug 5, 2026
The time.h header uses `bool` for the return type of `rmw_time_equal()` but does not directly include `<stdbool.h>`. This was previously provided transitively through `rcutils/time.h` -> `rcutils/types.h`, but ros2/rcutils#580 narrowed that include chain, breaking compilation of downstream C translation units. Signed-off-by: Siddhartha Banerjee <sbanerjee@overland.ai>
mjcarroll
pushed a commit
to ros2/rmw
that referenced
this pull request
Aug 6, 2026
The time.h header uses `bool` for the return type of `rmw_time_equal()` but does not directly include `<stdbool.h>`. This was previously provided transitively through `rcutils/time.h` -> `rcutils/types.h`, but ros2/rcutils#580 narrowed that include chain, breaking compilation of downstream C translation units. Signed-off-by: Siddhartha Banerjee <sbanerjee@overland.ai>
This was referenced Aug 6, 2026
mjcarroll
pushed a commit
to ros2/rmw
that referenced
this pull request
Aug 6, 2026
The time.h header uses `bool` for the return type of `rmw_time_equal()` but does not directly include `<stdbool.h>`. This was previously provided transitively through `rcutils/time.h` -> `rcutils/types.h`, but ros2/rcutils#580 narrowed that include chain, breaking compilation of downstream C translation units. (cherry picked from commit 5f21342) Signed-off-by: Siddhartha Banerjee <sbanerjee@overland.ai> Co-authored-by: banerjs-overland <sbanerjee@overland.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added missing headers
Did you use Generative AI?
Claude Opus 4.7