Skip to content

Last rolling sync before Ubuntu Resolute#6117

Open
mini-1235 wants to merge 4 commits intoros-navigation:mainfrom
mini-1235:rolling/sync/0429
Open

Last rolling sync before Ubuntu Resolute#6117
mini-1235 wants to merge 4 commits intoros-navigation:mainfrom
mini-1235:rolling/sync/0429

Conversation

@mini-1235
Copy link
Copy Markdown
Collaborator


Basic Info

Info Please fill out this column
Ticket(s) this addresses (add tickets here #1)
Primary OS tested on (Ubuntu, MacOS, Windows)
Robotic platform tested on (Steve's Robot, gazebo simulation of Tally, hardware turtlebot)
Does this PR contain AI generated software? (No; Yes and it is marked inline in the code)
Was this PR description generated by AI software? Out of respect for maintainers, AI for human-to-human communications are banned

Description of contribution in a few bullet points

Description of documentation updates required from your changes

Description of how this change was tested


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists
  • Should this be backported to current distributions? If so, tag with backport-*.

@mini-1235 mini-1235 marked this pull request as draft April 29, 2026 15:50
@mini-1235
Copy link
Copy Markdown
Collaborator Author

This depends on #6116, turning this into draft now

Comment thread nav2_rviz_plugins/src/docking_panel.cpp
@SteveMacenski
Copy link
Copy Markdown
Member

I saw the ament issue yesterday as well but I'm in the middle of something unrelated so I need to wrap that up first. Glad someone got to it 😉

@mini-1235 mini-1235 marked this pull request as ready for review April 30, 2026 21:53
@mini-1235
Copy link
Copy Markdown
Collaborator Author

Do we have a mergify bot that can rebase for us :)

@mini-1235
Copy link
Copy Markdown
Collaborator Author

@Mergifyio rebase

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Apr 30, 2026

rebase

❌ Unable to rebase: Mergify can't impersonate mini-1235

Details

User mini-1235 used as bot_account is unknown. Please make sure {login} exists and has logged into the Mergify dashboard.

@SteveMacenski
Copy link
Copy Markdown
Member

https://github.com/Mergifyio rebase

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Apr 30, 2026

Deprecation notice: This pull request comes from a fork and was rebased using bot_account impersonation. This capability will be removed on July 1, 2026. After this date, the rebase action will no longer be able to rebase fork pull requests with this configuration. Please switch to the update action/command to ensure compatibility going forward.

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Apr 30, 2026

rebase

✅ Branch has been successfully rebased

@SteveMacenski
Copy link
Copy Markdown
Member

SteveMacenski commented Apr 30, 2026

@mini-1235 same error on the core build job


rviz_rendering_tests: No definition of [ament_index_cpp] for OS version [noble]
rviz_rendering: No definition of [eigen3_cmake_module] for OS version [noble]
rviz2: No definition of [sensor_msgs] for OS version [noble]
rviz_default_plugins: No definition of [ament_lint_auto] for OS version [noble]
rviz_common: No definition of [ament_lint_auto] for OS version [noble]
behaviortree_cpp: No definition of [ament_cmake_gtest] for OS version [noble]
rviz_visual_testing_framework: No definition of [ament_lint_auto] for OS version [noble]
rviz_ogre_vendor: No definition of [ament_lint_auto] for OS version [noble]

Exited with code exit status 1

@mini-1235
Copy link
Copy Markdown
Collaborator Author

mini-1235 commented Apr 30, 2026

I think that we are calling rosdep update as well in circle ci, so that probably needs to be commented out as well. I will take a look when I get my laptop with me

But I can see the CI image workflow is already green though, so that's a good signal

@SteveMacenski
Copy link
Copy Markdown
Member

Mhm true. I had played around with pinning the version of rosdep to a commit before the 26.04 migration. This is actually what I've done before on my own personal machine to make rosdep work during times when my computer is out of sync with rolling. You've probably seen my commits trying to do that in your other PR that I reverted.

This may be the reason that wasn't working before. We could also try that. Then we can use rosdep update, if we're pointing at the index-v4.yaml from a git commit ~pre-April 20th. It wasn't working for me and still pulling in master so I eventually gave up for the moment since I was in the middle of doing something else unrelated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants