Skip to content

fix(mobile): fix composer command popover legibility - #5865

Closed
mohamedmastouri-hue wants to merge 2 commits into
pingdotgg:mainfrom
mohamedmastouri-hue:fix-issue-5859
Closed

fix(mobile): fix composer command popover legibility#5865
mohamedmastouri-hue wants to merge 2 commits into
pingdotgg:mainfrom
mohamedmastouri-hue:fix-issue-5859

Conversation

@mohamedmastouri-hue

@mohamedmastouri-hue mohamedmastouri-hue commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

This PR resolves legibility issues on the mobile command popover where the list options blended into the background lines.

  • Changed LiquidGlassView effect from clear to regular to correctly blur the background behind the popover.
  • Updated the row's bottom border color so it adjusts for light/dark modes instead of being invisible in light mode.

Fixes #5859


Note

Low Risk
Mobile UI-only styling and a small string helper extraction with tests; no auth, data, or API changes.

Overview
Improves contrast and row separation on the mobile composer command popover so list items don’t blend into the background.

On devices with Liquid Glass, PopoverSurface now uses effect="regular" instead of "clear" so the backdrop blurs correctly behind the popover. Command row dividers take isDarkMode and use a light border in dark mode and a dark border in light mode, replacing a fixed semi-transparent white line that was hard to see in light mode.

Empty/loading placeholder strings are unchanged in behavior but moved to composerCommandEmptyText in composerCommandPopoverText.ts, with unit tests covering trigger-specific copy.

Reviewed by Cursor Bugbot for commit e231018. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix composer command popover legibility in light and dark mode

  • Changes the LiquidGlassView effect in ComposerCommandPopover from "clear" to "regular" to improve popover surface legibility.
  • Fixes the CommandRow divider color to use a dark alpha (rgba(0,0,0,0.1)) in light mode instead of always using a white alpha, making separators visible on light backgrounds.
  • Extracts the emptyText helper into a standalone composerCommandEmptyText function in composerCommandPopoverText.ts with accompanying tests.

Macroscope summarized e231018.

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 77b61620-c5a7-4716-8082-f442d2635cb4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Aug 9, 2026
Comment thread apps/mobile/src/features/threads/ComposerCommandPopover.tsx Outdated

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 503b5d2. Configure here.

Comment thread apps/mobile/src/features/threads/ComposerCommandPopover.tsx Outdated
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Aug 9, 2026
@macroscopeapp

macroscopeapp Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved e231018

This PR contains simple UI styling fixes for mobile popover legibility: changing a visual effect property, adding dark mode support for border colors, and extracting a text utility function with tests. No behavioral logic changes beyond the intended visual improvements.

You can customize Macroscope's approvability policy. Learn more.

mohamedmastouri-hue and others added 2 commits August 10, 2026 12:56
- Change LiquidGlassView effect from 'clear' to 'regular' to properly blur background lines.
- Fix border color in light mode where white-on-white made list items blend together.

Fixes pingdotgg#5859

Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
@macroscopeapp
macroscopeapp Bot dismissed their stale review August 10, 2026 10:57

Dismissing prior approval to re-evaluate e231018

@github-actions github-actions Bot added size:M 30-99 changed lines (additions + deletions). and removed size:XS 0-9 changed lines (additions + deletions). labels Aug 10, 2026
@juliusmarminge

Copy link
Copy Markdown
Member

Closing as superseded by merged #6370, which moved the mobile command popover onto the current shared GlassSurface implementation and covers the legibility/rendering behavior on the current architecture. Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: mobile menu for skill selection is hard to read

2 participants