fix(mobile): fix composer command popover legibility - #5865
fix(mobile): fix composer command popover legibility#5865mohamedmastouri-hue wants to merge 2 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 503b5d2. Configure here.
ApprovabilityVerdict: Approved e231018 This PR contains simple UI styling fixes for mobile popover legibility: changing a visual effect property, adding dark mode support for border colors, and extracting a text utility function with tests. No behavioral logic changes beyond the intended visual improvements. You can customize Macroscope's approvability policy. Learn more. |
- Change LiquidGlassView effect from 'clear' to 'regular' to properly blur background lines. - Fix border color in light mode where white-on-white made list items blend together. Fixes pingdotgg#5859 Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
503b5d2 to
e231018
Compare
Dismissing prior approval to re-evaluate e231018
|
Closing as superseded by merged #6370, which moved the mobile command popover onto the current shared GlassSurface implementation and covers the legibility/rendering behavior on the current architecture. Thanks for the contribution. |

This PR resolves legibility issues on the mobile command popover where the list options blended into the background lines.
LiquidGlassVieweffect fromcleartoregularto correctly blur the background behind the popover.Fixes #5859
Note
Low Risk
Mobile UI-only styling and a small string helper extraction with tests; no auth, data, or API changes.
Overview
Improves contrast and row separation on the mobile composer command popover so list items don’t blend into the background.
On devices with Liquid Glass,
PopoverSurfacenow useseffect="regular"instead of"clear"so the backdrop blurs correctly behind the popover. Command row dividers takeisDarkModeand use a light border in dark mode and a dark border in light mode, replacing a fixed semi-transparent white line that was hard to see in light mode.Empty/loading placeholder strings are unchanged in behavior but moved to
composerCommandEmptyTextincomposerCommandPopoverText.ts, with unit tests covering trigger-specific copy.Reviewed by Cursor Bugbot for commit e231018. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Fix composer command popover legibility in light and dark mode
LiquidGlassVieweffect inComposerCommandPopoverfrom"clear"to"regular"to improve popover surface legibility.CommandRowdivider color to use a dark alpha (rgba(0,0,0,0.1)) in light mode instead of always using a white alpha, making separators visible on light backgrounds.emptyTexthelper into a standalonecomposerCommandEmptyTextfunction incomposerCommandPopoverText.tswith accompanying tests.Macroscope summarized e231018.