[release-4.10] Bug 2048836: Use ip command to check for ipv6 addresses - #2938
Conversation
For some reason the nmcli call to determine the number of ipv6 addresses on an interface is sometimes returning a blank line as part of the output. This causes a single address to look like 2 because we're just checking the line count and makes us incorrectly set "ipv6.may-fail no" on the interface. This causes the connection to fail and prevents ovs-configuration from completing. Here's some example output from an affected system: [root@master-0-0 core]# nmcli -m multiline --get-values ip6.address conn show 84a523ff-ee8a-4a29-94ca-47590eb0cb76 IP6.ADDRESS[1]:fe80::5054:ff:fe6e:6923/64 [root@master-0-0 core]# Additionally, we have seen another case where the link-local address from both the baremetal and provisioning networks shows up in the output of this command. That will also fail because we're just looking for line count > 1. This change modifies the check to use the ip command on the interface directly, so we should only get the addresses on the interface itself and we can use jq to filter out the ones we're not interested in. Although the bug specifically related to ipv6 addresses, in theory a similar issue could exist for ipv4 so that check is also converted.
|
@openshift-cherrypick-robot: Bugzilla bug 2047445 has been cloned as Bugzilla bug 2048836. Retitling PR to link against new bug. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
Bot
changed the title
openshift-ci
Bot
added
bugzilla/severity-urgent
|
@openshift-cherrypick-robot: This pull request references Bugzilla bug 2048836, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
openshift-ci
Bot
added
the
approved
|
/test e2e-metal-ipi-ovn-dualstack |
|
/test e2e-ovn-step-registry |
|
patch worked correctly on ci/prow/e2e-ovn-step-registry. dualstack didn't get far enough /test ci/prow/e2e-ovn-step-registry |
|
@trozet: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-ovn-step-registry |
|
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
/label cherry-pick-approved |
openshift-ci
Bot
added
the
cherry-pick-approved
knobunc
added
the
staff-eng-approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kikisdeliveryservice, knobunc, openshift-cherrypick-robot, trozet The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: Bugzilla bug 2048836 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
8 participants
This is an automated cherry-pick of #2934
/assign aravindhp