Bug 2047445: Use ip command to check for ipv6 addresses by cybertron · Pull Request #2934 · openshift/machine-config-operator

cybertron · 2022-01-27T22:09:37Z

For some reason the nmcli call to determine the number of ipv6
addresses on an interface is sometimes returning a blank line as
part of the output. This causes a single address to look like 2
because we're just checking the line count and makes us incorrectly
set "ipv6.may-fail no" on the interface. This causes the connection
to fail and prevents ovs-configuration from completing.

Here's some example output from an affected system:

[root@master-0-0 core]# nmcli -m multiline --get-values ip6.address conn show 84a523ff-ee8a-4a29-94ca-47590eb0cb76
IP6.ADDRESS[1]:fe80::5054:ff:fe6e:6923/64

[root@master-0-0 core]#

Additionally, we have seen another case where the link-local address
from both the baremetal and provisioning networks shows up in the
output of this command. That will also fail because we're just
looking for line count > 1.

This change modifies the check to use the ip command on the interface
directly (instead of the connection profile) so we should only get
the addresses on the interface, and we can filter out non-ipv6 ones
with jq. Hopefully this will be more robust than grepping and line
counting nmcli output.

- What I did

- How to verify it

- Description for the changelog

openshift-ci · 2022-01-27T22:09:43Z

@cybertron: This pull request references Bugzilla bug 2047445, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @anuragthehatter

Details

In response to this:

Bug 2047445: Use ip command to check for ipv6 addresses

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cybertron · 2022-01-27T22:09:57Z

/test e2e-metal-ipi-ovn-dualstack

kikisdeliveryservice · 2022-01-27T22:13:56Z

PTAL

/assign @knobunc @trozet

For some reason the nmcli call to determine the number of ipv6 addresses on an interface is sometimes returning a blank line as part of the output. This causes a single address to look like 2 because we're just checking the line count and makes us incorrectly set "ipv6.may-fail no" on the interface. This causes the connection to fail and prevents ovs-configuration from completing. Here's some example output from an affected system: [root@master-0-0 core]# nmcli -m multiline --get-values ip6.address conn show 84a523ff-ee8a-4a29-94ca-47590eb0cb76 IP6.ADDRESS[1]:fe80::5054:ff:fe6e:6923/64 [root@master-0-0 core]# Additionally, we have seen another case where the link-local address from both the baremetal and provisioning networks shows up in the output of this command. That will also fail because we're just looking for line count > 1. This change modifies the check to use the ip command on the interface directly, so we should only get the addresses on the interface itself and we can use jq to filter out the ones we're not interested in. Although the bug specifically related to ipv6 addresses, in theory a similar issue could exist for ipv4 so that check is also converted.

cybertron · 2022-01-27T22:40:21Z

/test e2e-metal-ipi-ovn-dualstack

This latest version is based on feedback from @trozet and @jcaamano.

jcaamano · 2022-01-28T09:15:45Z

/lgtm

jcaamano · 2022-01-28T09:20:52Z

/test e2e-metal-ipi-ovn-dualstack
/test e2e-ovn-step-registry

jcaamano · 2022-01-28T12:26:23Z

/assign @kikisdeliveryservice

jcaamano · 2022-01-28T13:44:27Z

/retest-required

trozet

/lgtm

cybertron · 2022-01-28T16:16:37Z

/retest-required

cgwalters · 2022-01-28T17:18:18Z

(clearly this should be in a compiled language, not shell; hopefully we can do that at some point)

/approve

openshift-ci · 2022-01-28T17:18:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, cybertron, jcaamano, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [cgwalters]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2022-01-28T17:36:21Z

/bugzilla refresh

The requirements for Bugzilla bugs have changed (BZs linked to PRs on master branch need to target OCP 4.11), recalculating validity.

openshift-ci · 2022-01-28T17:36:25Z

@openshift-bot: This pull request references Bugzilla bug 2047445, which is invalid:

expected the bug to target the "4.11.0" release, but it targets "4.10.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

The requirements for Bugzilla bugs have changed (BZs linked to PRs on master branch need to target OCP 4.11), recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-01-31T04:01:41Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-31T06:25:41Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-31T06:49:40Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-31T07:01:41Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-31T07:37:41Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-31T08:01:42Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-31T08:13:41Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-31T08:25:41Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-31T09:37:41Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-31T10:01:42Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-31T10:25:40Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-31T10:37:42Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-31T11:50:43Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-31T12:14:43Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-31T14:54:42Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

aravindhp · 2022-01-31T16:15:25Z

/hold

e2e-agnostic-upgrade is perma failing. @trozet @cybertron please investigate and see if this is because of this PR or if an override is needed.

openshift-ci · 2022-01-31T16:46:12Z

@cybertron: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-single-node	`e19fcc4`	link	false	`/test e2e-aws-single-node`
ci/prow/e2e-vsphere-upgrade	`e19fcc4`	link	false	`/test e2e-vsphere-upgrade`
ci/prow/e2e-aws-workers-rhel7	`e19fcc4`	link	false	`/test e2e-aws-workers-rhel7`
ci/prow/okd-e2e-aws	`e19fcc4`	link	false	`/test okd-e2e-aws`
ci/prow/e2e-aws-workers-rhel8	`e19fcc4`	link	false	`/test e2e-aws-workers-rhel8`
ci/prow/e2e-aws-disruptive	`e19fcc4`	link	false	`/test e2e-aws-disruptive`
ci/prow/e2e-aws-upgrade-single-node	`e19fcc4`	link	false	`/test e2e-aws-upgrade-single-node`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

trozet · 2022-01-31T17:04:46Z

@aravindhp looks like this job is perma fail across all PRs. The e2e-agnostic-upgrade uses openshift-sdn (not OVN), so the changes in this PR are never executed. The jobs that exercise this patch are:

ci/prow/e2e-metal-ipi-ovn-dualstack — Job succeeded.
ci/prow/e2e-ovn-step-registry — Job succeeded.

vpickard · 2022-01-31T20:26:45Z

/cherry-pick release-4.10

openshift-cherrypick-robot · 2022-01-31T20:26:46Z

@vpickard: once the present PR merges, I will cherry-pick it on top of release-4.10 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kikisdeliveryservice · 2022-01-31T20:34:14Z

As this PR is not exercised in the current e2e-agnostic-upgrade job, the severity of the underlying bug and the current permafail state of the upgrade, overriding on this PR to expedite the fix

/override ci/prow/e2e-agnostic-upgrade
/hold cancel

openshift-ci · 2022-01-31T20:34:44Z

@kikisdeliveryservice: Overrode contexts on behalf of kikisdeliveryservice: ci/prow/e2e-agnostic-upgrade

Details

In response to this:

As this PR is not exercised in the current e2e-agnostic-upgrade job, the severity of the underlying bug and the current permafail state of the upgrade, overriding on this PR to expedite the fix

/override ci/prow/e2e-agnostic-upgrade
/hold cancel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-01-31T22:03:41Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2022-01-31T23:27:37Z

@cybertron: All pull requests linked via external trackers have merged:

openshift/machine-config-operator#2934

Bugzilla bug 2047445 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2047445: Use ip command to check for ipv6 addresses

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2022-01-31T23:28:18Z

@aravindhp: new pull request created: #2938

Details

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Bug 2047445: Use ip command to check for ipv6 addresses

openshift-ci Bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 27, 2022

openshift-ci Bot requested a review from anuragthehatter January 27, 2022 22:09

openshift-ci Bot requested review from cheesesashimi and kikisdeliveryservice January 27, 2022 22:11

openshift-ci Bot assigned knobunc and trozet Jan 27, 2022

cybertron force-pushed the ipv6-detection-ip branch from 649598d to e19fcc4 Compare January 27, 2022 22:34

openshift-ci Bot assigned jcaamano Jan 28, 2022

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2022

openshift-ci Bot assigned kikisdeliveryservice Jan 28, 2022

trozet approved these changes Jan 28, 2022

View reviewed changes

This was referenced Jan 28, 2022

Bug 2046191: Rebase to upstream v0.64.6 openshift/kubernetes-nmstate#252

Closed

Bug 2047445: Filter out empty lines and link-local addrs from nmcli output #2933

Closed

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2022

openshift-ci Bot removed the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 28, 2022

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 31, 2022

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 31, 2022

openshift-merge-robot merged commit 4b65d78 into openshift:master Jan 31, 2022

openshift-cherrypick-robot mentioned this pull request Jan 31, 2022

[release-4.10] Bug 2048836: Use ip command to check for ipv6 addresses #2938

Merged

ptalgulk01 pushed a commit to ptalgulk01/machine-config-operator that referenced this pull request May 15, 2026

Merge pull request openshift#2934 from cybertron/ipv6-detection-ip

4939416

Bug 2047445: Use ip command to check for ipv6 addresses

Uh oh!

Conversation

cybertron commented Jan 27, 2022

Uh oh!

openshift-ci Bot commented Jan 27, 2022

Uh oh!

cybertron commented Jan 27, 2022

Uh oh!

kikisdeliveryservice commented Jan 27, 2022

Uh oh!

cybertron commented Jan 27, 2022

Uh oh!

jcaamano commented Jan 28, 2022

Uh oh!

jcaamano commented Jan 28, 2022

Uh oh!

jcaamano commented Jan 28, 2022

Uh oh!

jcaamano commented Jan 28, 2022

Uh oh!

trozet left a comment

Choose a reason for hiding this comment

Uh oh!

cybertron commented Jan 28, 2022

Uh oh!

cgwalters commented Jan 28, 2022

Uh oh!

openshift-ci Bot commented Jan 28, 2022

Uh oh!

openshift-bot commented Jan 28, 2022

Uh oh!

openshift-ci Bot commented Jan 28, 2022

Uh oh!

openshift-bot commented Jan 31, 2022

Uh oh!

openshift-bot commented Jan 31, 2022

Uh oh!

openshift-bot commented Jan 31, 2022

Uh oh!

openshift-bot commented Jan 31, 2022

Uh oh!

openshift-bot commented Jan 31, 2022

Uh oh!

openshift-bot commented Jan 31, 2022

Uh oh!

openshift-bot commented Jan 31, 2022

Uh oh!

openshift-bot commented Jan 31, 2022

Uh oh!

openshift-bot commented Jan 31, 2022

Uh oh!

openshift-bot commented Jan 31, 2022

Uh oh!

openshift-bot commented Jan 31, 2022

Uh oh!

openshift-bot commented Jan 31, 2022

Uh oh!

openshift-bot commented Jan 31, 2022

Uh oh!

openshift-bot commented Jan 31, 2022

Uh oh!

openshift-bot commented Jan 31, 2022

Uh oh!

aravindhp commented Jan 31, 2022

Uh oh!

openshift-ci Bot commented Jan 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

trozet commented Jan 31, 2022

Uh oh!

vpickard commented Jan 31, 2022

Uh oh!

openshift-cherrypick-robot commented Jan 31, 2022

Uh oh!

kikisdeliveryservice commented Jan 31, 2022

Uh oh!

openshift-ci Bot commented Jan 31, 2022

Uh oh!

openshift-bot commented Jan 31, 2022

Uh oh!

openshift-ci Bot commented Jan 31, 2022 •

edited

Loading