Skip to content

feat: freeze review runtime assets - #128

Merged
norvalbv merged 1 commit into
mainfrom
codex/review-stack-16-frozen-assets
Jul 20, 2026
Merged

feat: freeze review runtime assets#128
norvalbv merged 1 commit into
mainfrom
codex/review-stack-16-frozen-assets

Conversation

@norvalbv

@norvalbv norvalbv commented Jul 19, 2026

Copy link
Copy Markdown
Owner

Review 16 of 20 — hardened replacement stack. This is not a patch-equivalent split of #95; it is one layer of the larger redesign.

What this PR does

Completes the frozen executable/runtime asset capture used by review gates:

  • Builds an exact, sorted registry of reviewer briefs, skills, packaged scripts, and baseline modules.
  • Reads assets through descriptor-pinned paths and verifies source/copy/source identity.
  • Preserves the executable-vs-non-executable mode class.
  • Rejects unexpected tree entries, symlink escapes, special files, torn capture, and registry drift.
  • Rolls back incomplete private copies instead of leaving a partially trusted runtime.

Why this slice exists

The review should execute one authenticated set of reviewer instructions and scripts. If target-controlled assets can change between discovery and execution, the reported verdict no longer describes a single reproducible snapshot.

Review carefully

  • The registry is complete for Claude, Cursor, Codex/devkit reviewers, and baseline modules.
  • Exact-tree validation catches both missing and injected assets.
  • Descriptor-pinned reads close rename/symlink races.
  • Executable mode semantics survive copying.
  • Capture failure cannot leave a runtime that later appears valid.

Explicit non-goals

Stack position

Review bottom-up. These PRs currently target their predecessor branches; do not merge a middle PR directly to main. After review, successors must be retargeted/rebased as predecessors land, unless an explicit stack-collapse landing process is agreed.

Size and evidence

  • 5 files
  • +272 / -18 lines
  • Includes frozen-asset, fingerprint, reviewer-runtime, and rollback regression coverage.
  • Originally published through devkit ship.
  • This description update changes GitHub metadata only.

@coderabbitai

coderabbitai Bot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@norvalbv, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 29 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 07a8055c-61aa-41c9-b243-30029e9f3829

📥 Commits

Reviewing files that changed from the base of the PR and between cad7d80 and af45337.

📒 Files selected for processing (5)
  • cli/__tests__/review-asset-runtime.test.mts
  • cli/__tests__/review-runtime-fingerprint.test.mts
  • cli/lib/ship/review/asset-runtime.mts
  • cli/lib/ship/review/runtime-fingerprint.mts
  • gate-engine/review/runtime.mts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/review-stack-16-frozen-assets

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Freezes the exact reviewer runtime module registry into a private review data root using descriptor-pinned reads, source-copy-source verification, executable-class preservation, and a manifest fingerprint. Baseline review modules are registered explicitly so final and merge-base runs execute identical packaged code.
@norvalbv
norvalbv force-pushed the codex/review-stack-16-frozen-assets branch from ec4bda4 to af45337 Compare July 20, 2026 16:42
@norvalbv
norvalbv merged commit f11c440 into main Jul 20, 2026
2 checks passed
norvalbv added a commit that referenced this pull request Jul 22, 2026
norvalbv added a commit that referenced this pull request Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant