refactor: add review runtime fingerprints - #115
Conversation
|
Warning Review limit reached
Next review available in: 8 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
075e96a to
3f440f1
Compare
Stacked on #114. Adds dormant foundations for freezing trusted review inputs before the public command is exposed: - manages the durable `.devkit/review-runs/` output ignore through init/clean - fingerprints file content and Git-relevant executable identity - fingerprints directories deterministically while dereferencing symlinks - rejects cyclic, dangling, and unsupported runtime paths - verifies multiple expected/absent paths through a symlink-safe CLI entrypoint Verification: - focused cache/fingerprint tests (15/15) - `bun run typecheck` - `bun run lint` (two inherited warnings outside this diff) - `bun run build` - `node cli/index.mts doctor` - Fallow introduced-debt scan clean - dedicated correctness review PASS after fixing its symlink-entrypoint blocker
b698802 to
b2c77e5
Compare
## Summary - capture a target checkout's complete final Git tree without mutating its HEAD, refs, files, or real index - preserve committed, staged, unstaged, deleted, binary, symlink, executable, force-staged ignored, and non-ignored untracked state - fail closed on sparse/skip-worktree indexes, unstable files/indexes/ignore rules/projection candidates, producer failures, and signals - reuse one NUL-safe projection candidate registry while preserving ship/reship behavior ## Stack Depends on #115. The public `devkit review` command remains unreachable until the final stack slice. ## Validation - 14 hermetic snapshot tests - gate projection tests - ship suite: 61/61 - reship regression suite - full suite: 1,550 passed, 5 skipped - typecheck, lint, build, doctor, shellcheck, and Fallow new-only gate
refactor: add review runtime fingerprints
## Summary - capture a target checkout's complete final Git tree without mutating its HEAD, refs, files, or real index - preserve committed, staged, unstaged, deleted, binary, symlink, executable, force-staged ignored, and non-ignored untracked state - fail closed on sparse/skip-worktree indexes, unstable files/indexes/ignore rules/projection candidates, producer failures, and signals - reuse one NUL-safe projection candidate registry while preserving ship/reship behavior ## Stack Depends on #115. The public `devkit review` command remains unreachable until the final stack slice. ## Validation - 14 hermetic snapshot tests - gate projection tests - ship suite: 61/61 - reship regression suite - full suite: 1,550 passed, 5 skipped - typecheck, lint, build, doctor, shellcheck, and Fallow new-only gate
refactor: add review runtime fingerprints
## Summary - capture a target checkout's complete final Git tree without mutating its HEAD, refs, files, or real index - preserve committed, staged, unstaged, deleted, binary, symlink, executable, force-staged ignored, and non-ignored untracked state - fail closed on sparse/skip-worktree indexes, unstable files/indexes/ignore rules/projection candidates, producer failures, and signals - reuse one NUL-safe projection candidate registry while preserving ship/reship behavior ## Stack Depends on #115. The public `devkit review` command remains unreachable until the final stack slice. ## Validation - 14 hermetic snapshot tests - gate projection tests - ship suite: 61/61 - reship regression suite - full suite: 1,550 passed, 5 skipped - typecheck, lint, build, doctor, shellcheck, and Fallow new-only gate
1 participant
What this PR does
Adds deterministic fingerprints for files and directories used by the private review runtime.
.devkit/review-runs/to managed ignored output.Why this slice exists
Later slices copy snapshots, setup and reviewer assets into private directories. Fingerprints are the evidence that bytes did not change between capture, execution and verification.
Review carefully
Explicit non-goals
devkit reviewcommand.Stack position
These PRs currently target one another. Landing them individually requires retargeting/rebasing each successor after its predecessor lands; otherwise wait until the full stack has been reviewed and use an agreed stack-collapse strategy.
Size and validation evidence
devkit ship; focused regression tests are included in the diff.