Conversation
- tool-sandbox.mdx: fix Tool Sandbox mental model — the outer sessions exec grant is built from every trusted PATH directory (allow-listing every executable found there), not just the initial program and shims. Verified against crates/nono-cli/src/tool-sandbox/platform/linux.rs and reproduced on a real Landlock host (#1630). - overview.mdx: update "Resource Exhaustion" — memory and process-count are now enforced on Linux via cgroup v2 (memory.max, pids.max); CPU/disk and macOS remain unenforced. Verified against resource_cgroup.rs and reproduced with --memory/--max-processes triggering real OOM kills and fork EAGAIN (#1664). - profiles-groups.mdx: fix "Hooks" section — profile-level hooks.<target> installation was removed in v0.44.0 and now only prints a note; actual wiring lives in pack package.json `wiring` directives. Clarify this is distinct from Session Hooks (#1645). - profiles-groups.mdx: fix heading nesting — promote "AF_UNIX Socket Grants" and "Working Directory" from h3 to h2 so theyre no longer nested under "Session Hooks" (#1644). Signed-off-by: Aleksy Siek <aleksy@nolabs.ai>
Contributor
PR Review SummarySize
Affected cratesNo crate source directories are directly affected. Blast radius — ContainedThis PR touches: unknown file types Updated automatically on each push to this PR. |
Signed-off-by: Aleksy Siek <aleksy@nolabs.ai>
MateSaary
approved these changes
Aug 18, 2026
1 task
levonk
pushed a commit
to levonk/nono
that referenced
this pull request
Sep 4, 2026
…-ai#1668) * docs: correct outdated/inaccurate sections across 4 doc pages - tool-sandbox.mdx: fix Tool Sandbox mental model — the outer sessions exec grant is built from every trusted PATH directory (allow-listing every executable found there), not just the initial program and shims. Verified against crates/nono-cli/src/tool-sandbox/platform/linux.rs and reproduced on a real Landlock host (nolabs-ai#1630). - overview.mdx: update "Resource Exhaustion" — memory and process-count are now enforced on Linux via cgroup v2 (memory.max, pids.max); CPU/disk and macOS remain unenforced. Verified against resource_cgroup.rs and reproduced with --memory/--max-processes triggering real OOM kills and fork EAGAIN (nolabs-ai#1664). - profiles-groups.mdx: fix "Hooks" section — profile-level hooks.<target> installation was removed in v0.44.0 and now only prints a note; actual wiring lives in pack package.json `wiring` directives. Clarify this is distinct from Session Hooks (nolabs-ai#1645). - profiles-groups.mdx: fix heading nesting — promote "AF_UNIX Socket Grants" and "Working Directory" from h3 to h2 so theyre no longer nested under "Session Hooks" (nolabs-ai#1644). Signed-off-by: Aleksy Siek <aleksy@nolabs.ai> * fix: rewrite session hook section Signed-off-by: Aleksy Siek <aleksy@nolabs.ai> --------- Signed-off-by: Aleksy Siek <aleksy@nolabs.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
crates/nono-cli/src/tool-sandbox/platform/linux.rsand reproduced on a real Landlock host.memory.max,pids.max); CPU/disk and macOS remain unenforced. Verified againstresource_cgroup.rsand reproduced with--memory/--max-processestriggering real OOM kills and forkEAGAIN.hooks.<target>installation was removed in v0.44.0 and now only prints a note; actual wiring lives in packpackage.jsonwiringdirectives. Clarify this is distinct from Session Hooks.Closes #1630
Closes #1664
Closes #1645
Closes #1644
Verification
All four claims were manually verified, not just read from source:
nono run --memory 32Mtriggered a real cgroup v2 OOM kill of the whole process tree, andnono run --max-processes 5triggered kernel forkEAGAINwithout killing anything — confirming docs: "Resource Exhaustion" section in architecture overview is outdated — memory/process limits now exist #1664's corrected text.--memory/--max-processes("resource limits are only enforced on Linux (cgroup v2)").profile_runtime.rs::install_profile_hooksto confirm profile-levelhooksinstallation was removed in v0.44.0 (CHANGELOG confirms), which is a stronger correction than Docs: How do hooks work? #1645 originally asked for.Test plan