Conversation
jphickey
approved these changes
Oct 26, 2023
jphickey
added
the
CCB:Ready
dzbaker
added
CCB:Approved
2 tasks
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Oct 30, 2023
*Combines:* sample_app v1.3.0-rc4+dev56 ci_lab v2.5.0-rc4+dev51 sch_lab v2.5.0-rc4+dev61 **Includes:** *sample_app* - nasa/sample_app#189 - nasa/sample_app#195 - nasa/sample_app#198 - nasa/sample_app#201 - nasa/sample_app#205 - nasa/sample_app#208 - nasa/sample_app#209 *ci_lab* - nasa/ci_lab#148 *sch_lab* - nasa/sch_lab#151 Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com> Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Oct 30, 2023
*Combines:* sample_app v1.3.0-rc4+dev56 ci_lab v2.5.0-rc4+dev51 sch_lab v2.5.0-rc4+dev61 **Includes:** *sample_app* - nasa/sample_app#189 - nasa/sample_app#195 - nasa/sample_app#198 - nasa/sample_app#201 - nasa/sample_app#205 - nasa/sample_app#208 - nasa/sample_app#209 *ci_lab* - nasa/ci_lab#148 *sch_lab* - nasa/sch_lab#151 Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com> Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
thnkslprpt
deleted the
fix-197-refactor-sample-app-to-remove-multiple-returns
branch
October 31, 2023 07:05
segeljakt
pushed a commit
to LeoDOS-Project/LeoDOS
that referenced
this pull request
Mar 22, 2026
*Combines:* sample_app v1.3.0-rc4+dev56 ci_lab v2.5.0-rc4+dev51 sch_lab v2.5.0-rc4+dev61 **Includes:** *sample_app* - nasa/sample_app#189 - nasa/sample_app#195 - nasa/sample_app#198 - nasa/sample_app#201 - nasa/sample_app#205 - nasa/sample_app#208 - nasa/sample_app#209 *ci_lab* - nasa/ci_lab#148 *sch_lab* - nasa/sch_lab#151 Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com> Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
SAMPLE_APP_Init()andSAMPLE_APP_Process()were refactored to now have a single exit point.The Sample App now exhibits the preferred pattern of cFS more closely - encouraging new users to follow the same guidelines.
A few spelling inconsistencies and spacing issues were rectified as well.
Testing performed
GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully.
Tested locally - coverage level unchanged by this PR (testing still misses 4 branches in sample_app as per the main branch).
Expected behavior changes
Behavior unchanged - failures during these 2 functions will fail subsequent checks of
== CFE_SUCCESSand fall through to the exit point at the end of the function to return the relevant error code.System(s) tested on
Intel(R) Celeron(R) N4100 CPU @ 1.10GHz x86_64
Debian GNU/Linux 11 (bullseye)
Current main branch of cFS.
Contributor Info
Avi Weiss @thnkslprpt