Skip to content

Fix #188, Apply consistent Event ID names to common events - #189

Merged
dzbaker merged 1 commit into
nasa:mainfrom
thnkslprpt:fix-188-apply-consistent-event-id-names
Oct 30, 2023
Merged

Fix #188, Apply consistent Event ID names to common events#189
dzbaker merged 1 commit into
nasa:mainfrom
thnkslprpt:fix-188-apply-consistent-event-id-names

Conversation

@thnkslprpt

@thnkslprpt thnkslprpt commented Oct 21, 2022

Copy link
Copy Markdown
Contributor

Checklist

Describe the contribution

Testing performed
Only GitHub CI actions.

Expected behavior changes
No impact on code behavior (no logic changes).
Consistent Event ID names for the events which are common to all/most cFS components and apps will improve consistency and ease make code review/debugging easier.

Contributor Info
Avi Weiss @thnkslprpt

@dzbaker dzbaker added this to the Fornax milestone Nov 21, 2022
@dzbaker dzbaker modified the milestones: Fornax, Equuleus Dec 7, 2022
@dzbaker dzbaker added the CCB:Approved Indicates code approval by CCB label Oct 26, 2023
dzbaker added a commit to nasa/cFS that referenced this pull request Oct 30, 2023
*Combines:*

sample_app v1.3.0-rc4+dev56
ci_lab v2.5.0-rc4+dev51
sch_lab v2.5.0-rc4+dev61

**Includes:**

*sample_app*
- nasa/sample_app#189
- nasa/sample_app#195
- nasa/sample_app#198
- nasa/sample_app#201
- nasa/sample_app#205
- nasa/sample_app#208
- nasa/sample_app#209

*ci_lab*
- nasa/ci_lab#148

*sch_lab*
- nasa/sch_lab#151

Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com>
Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
@dzbaker dzbaker mentioned this pull request Oct 30, 2023
2 tasks
@dzbaker
dzbaker merged commit fcf1597 into nasa:main Oct 30, 2023
dzbaker added a commit to nasa/cFS that referenced this pull request Oct 30, 2023
*Combines:*

sample_app v1.3.0-rc4+dev56
ci_lab v2.5.0-rc4+dev51
sch_lab v2.5.0-rc4+dev61

**Includes:**

*sample_app*
- nasa/sample_app#189
- nasa/sample_app#195
- nasa/sample_app#198
- nasa/sample_app#201
- nasa/sample_app#205
- nasa/sample_app#208
- nasa/sample_app#209

*ci_lab*
- nasa/ci_lab#148

*sch_lab*
- nasa/sch_lab#151

Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com>
Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
@thnkslprpt
thnkslprpt deleted the fix-188-apply-consistent-event-id-names branch October 31, 2023 07:18
@dzbaker dzbaker modified the milestones: Equuleus, v7.0.0 Feb 12, 2026
segeljakt pushed a commit to LeoDOS-Project/LeoDOS that referenced this pull request Mar 22, 2026
*Combines:*

sample_app v1.3.0-rc4+dev56
ci_lab v2.5.0-rc4+dev51
sch_lab v2.5.0-rc4+dev61

**Includes:**

*sample_app*
- nasa/sample_app#189
- nasa/sample_app#195
- nasa/sample_app#198
- nasa/sample_app#201
- nasa/sample_app#205
- nasa/sample_app#208
- nasa/sample_app#209

*ci_lab*
- nasa/ci_lab#148

*sch_lab*
- nasa/sch_lab#151

Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com>
Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CCB:Approved Indicates code approval by CCB

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent Event ID naming

3 participants