Bug 2062730 - Return machine_name with each performance summary datum - #9776
Open
mstange wants to merge 2 commits into
Open
Bug 2062730 - Return machine_name with each performance summary datum#9776mstange wants to merge 2 commits into
mstange wants to merge 2 commits into
Conversation
We were using the key `submit_time` in the hand-built datum dicts, but then during serialization, `PerformanceDatumSerializer` was looking for a `job__submit_time` key instead. That's because we supply `source="job__submit_time"` in the serializer's constructor. The mismatch failed silently rather than raising: the field is declared `required=False, default=None`, so every datum serialized with `submit_time: null`, which left the graphs view with an Invalid Date for its retrigger times. Use `job__submit_time` so that the serializer finds the field.
This allows showing per-machine data in the graphs without requiring
separate requests for each job's job details.
The potential costs of this change are:
- Increased database query time
- Increased response size
The query already looks at job submit times so it's already looking
at the right table, so any query time regressions should be minor.
(Claude took a look in more detail and had more elaborate justifications
but I didn't understand them so I'm not copying them here.)
The response size grows, but gzip mostly takes care of it because there
aren't a lot of different machine names.
I measured a 1050-row response as an example, and it grew by 16.8% raw
and 3.2% gzipped ("0.6 bytes per row").
✅ Deploy Preview for treeherder ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #9775.
https://bugzilla.mozilla.org/show_bug.cgi?id=2062730
This allows showing per-machine data in the graphs without requiring separate requests for each job's job details.
The potential costs of this change are:
The query already looks at job submit times so it's already looking at the right table, so any query time regressions should be minor.
(Claude took a look in more detail and had more elaborate justifications but I didn't understand them so I'm not copying them here.)
The response size grows, but gzip mostly takes care of it because there aren't a lot of different machine names. I measured a 1050-row response as an example, and it grew by 16.8% raw and 3.2% gzipped ("0.6 bytes per row").
r? @gmierz