Bug 2062732 - Fix submit_time when using replicates=true - #9775
Open
mstange wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for treeherder ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mstange
changed the title
We were using the key `submit_time` in the hand-built datum dicts, but then during serialization, `PerformanceDatumSerializer` was looking for a `job__submit_time` key instead. That's because we supply `source="job__submit_time"` in the serializer's constructor. The mismatch failed silently rather than raising: the field is declared `required=False, default=None`, so every datum serialized with `submit_time: null`, which left the graphs view with an Invalid Date for its retrigger times. Use `job__submit_time` so that the serializer finds the field.
mstange
force-pushed
the
push-tklxqwxqtqop
branch
from
August 11, 2026 18:19
eb29c79 to
50191e4
Compare
Contributor
Author
|
I still see |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugzilla.mozilla.org/show_bug.cgi?id=2062732
We were using the key
submit_timein the hand-built datum dicts, but then during serialization,PerformanceDatumSerializerwas looking for ajob__submit_timekey instead.That's because we supply
source="job__submit_time"in the serializer's constructor.The mismatch failed silently rather than raising: the field is declared
required=False, default=None, so every datum serialized withsubmit_time: null, which left the graphs view with an Invalid Date for its retrigger times.Use
job__submit_timeso that the serializer finds the field.The fix is super short; most of this patch is the test.
r? @gmierz