message template changes - #3
Merged
Merged
Conversation
vgenev
approved these changes
Nov 20, 2018
vgenev
left a comment
vgenev
left a comment
Contributor
There was a problem hiding this comment.
I am happy with the changes
56 tasks
vgenev
added a commit
that referenced
this pull request
Nov 27, 2018
vgenev
added a commit
that referenced
this pull request
May 10, 2019
vgenev
added a commit
that referenced
this pull request
May 10, 2019
* adding circleCI setup (#1) (#2) * Develop (#8) * adding circleCI setup (#1) * message template changes (#3) * message template changes * added config to be loaded from environmental variables * added healthcheck * Added Dockerfile * Add Dockerfile and dockerignore * settings error fixed * healthcheckport renamed to port * kafka fix and log * Added happy line testing to action observable * Fix Chai deep euqal error * Added code to do code coverage * Added negative test case to the actions * Start unit tests for templates/index.js * changed /healtcheck to /health * Added negative test for templates index * fixed bug in the neagtive testing * Added last unit test for templates/index.js * changed version to 4.3.0 * Added two describe sections in the sendmailer unit test to increase test coverage * Add unit test fixes for send mail * changed code coverage to produce html report * Add last changes before pull request * Added .idea directory to gitignore * Added a back slash after the directory name * Ran git rm --cached .idea/workspace.xml to remove the .idea files * changed to * changed to .idea/* * changed to .idea/* * Unittetsts (#9) * Added happy line testing to action observable * Fix Chai deep euqal error * Added code to do code coverage * Added negative test case to the actions * Start unit tests for templates/index.js * Added negative test for templates index * fixed bug in the neagtive testing * Added last unit test for templates/index.js * Added two describe sections in the sendmailer unit test to increase test coverage * Add unit test fixes for send mail * changed code coverage to produce html report * Add last changes before pull request * Added .idea directory to gitignore * Added a back slash after the directory name * Ran git rm --cached .idea/workspace.xml to remove the .idea files * changed to * changed to .idea/* * changed to .idea/* * refactor the mailer and unit tests. changed the logging of the kafka consumer * WIP * WIP * wip * wip * wip * setup only not working * no marbles tape is used for the rest * setup test added. not finished * setup test with marbles * setup tests. might need to be reworked to be stubbed only * setup test finishing. coverage bad * WIP * switchMap changed to flatMap * version bumped up * got coverage over 80% * added troubleshooting info into README.md * consumer coverage 100 percent and unit and coverage added to circle ci * fixed readme and added istanbul coverage check * circleci setup * fix some more comments * fixed test:xunit script * ..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.