Feature/#559 circleci - #24
Merged
Merged
Conversation
* Added happy line testing to action observable * Fix Chai deep euqal error * Added code to do code coverage * Added negative test case to the actions * Start unit tests for templates/index.js * Added negative test for templates index * fixed bug in the neagtive testing * Added last unit test for templates/index.js * Added two describe sections in the sendmailer unit test to increase test coverage * Add unit test fixes for send mail * changed code coverage to produce html report * Add last changes before pull request * Added .idea directory to gitignore * Added a back slash after the directory name * Ran git rm --cached .idea/workspace.xml to remove the .idea files * changed to * changed to .idea/* * changed to .idea/*
ggrg
approved these changes
May 10, 2019
Contributor
Author
fixed and unit and coverage are passing |
ggrg
approved these changes
May 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
some circleci setup was left uncomentted