chore(har recorder): ensure we respect minimal mode - #32658
Merged
Simon Knott (Skn0tt) merged 2 commits intoSep 17, 2024
Conversation
Contributor
Test results for "tests 1"1 failed 2 flaky35487 passed, 659 skipped Merge workflow run. |
Dmitry Gozman (dgozman)
approved these changes
Sep 17, 2024
Simon Knott (Skn0tt)
added a commit
that referenced
this pull request
Sep 18, 2024
While working on #32658 I discovered that we're recording `securityDetails` for browser requests, but not for API requests. This PR fixes that.
Simon Knott (Skn0tt)
added a commit
that referenced
this pull request
Sep 18, 2024
Discovered working on #32658. We're recording the remote server address for browser requests, but not for API requests. This PR adds that for API requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #32653.
Adds some test coverage to ensure we respect minimal mode for API Requests in HAR tracing.
omitCookiesomitTimingomitSecurityDetailsomitServerIPomitPagesomitSizesomitScripts