Fix memory stream Nack ordering#4694
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request fixes an ordering bug in the in-memory events stream when using manual ack: a Nack() now forces the nacked event to be redelivered to the same subscriber before any later queued events are delivered. This aligns the memory stream behavior with the AckingNacking contract and prevents the race observed in CI.
Changes:
- Serialize manual-ack delivery per subscriber by queueing published events and dispatching them via a single per-subscriber manual-ack loop.
- Implement immediate redelivery on
Nack()within the manual-ack delivery loop (rather than waiting for the ack-wait timeout tick). - Extend
AckingNackingtest coverage by publishing a third message and asserting it is only received after the nacked message is redelivered.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| events/memory.go | Adds per-subscriber pending queue + notifier and a manual-ack dispatcher to ensure nacked events are redelivered before later queued events. |
| events/stream_test.go | Strengthens the manual-ack ordering test by adding an additional queued publish and validating delivery order around Nack(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4690
Closes #4693
Testing