[Merged by Bors] - feat(RingTheory/AdicCompletion): generalize universal property of IsAdicComplete - #31296
Closed
jjdishere wants to merge 135 commits into
Closed
Conversation
This reverts commit acd93bb.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ng_fontaine_theta
…ng_fontaine_theta
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…nprover-community/mathlib4 into jiedong_jiang_fontaine_theta
…eanprover-community/mathlib4 into jiedong_jiang_is_adic_complete
This reverts commit 380aa8f.
mathlib4-dependent-issues-bot
removed
the
blocked-by-other-PR
Collaborator
|
This PR/issue depends on: |
Collaborator
|
This pull request has conflicts, please merge |
mathlib4-merge-conflict-bot
added
the
merge-conflict
Member
|
Can you please fix the conflict? |
github-actions
Bot
removed
the
merge-conflict
Collaborator
Author
@riccardobrasca Thank you for reminding. Fixed. |
riccardobrasca
approved these changes
Nov 10, 2025
Contributor
|
✌️ jjdishere can now approve this pull request. To approve and merge a pull request, simply reply with |
ghost
added
the
delegated
Co-authored-by: Riccardo Brasca <riccardo.brasca@gmail.com>
Co-authored-by: Riccardo Brasca <riccardo.brasca@gmail.com>
Co-authored-by: Riccardo Brasca <riccardo.brasca@gmail.com>
Collaborator
Author
|
bors r+ |
mathlib-bors Bot
pushed a commit
that referenced
this pull request
Nov 10, 2025
…AdicComplete` (#31296) In this PR, we add APIs generalizing the universal property of `IsAdicComplete`. Namely, instead of requiring a family of compatible maps `M \to N/I^n`, we only require a subfamily of maps `M \to N/I^a n`. This would be used in #26388. Co-authored-by: Jiedong Jiang <emailboxofjjd@163.com> Co-authored-by: Kenny Lau <kc_kennylau@yahoo.com.hk>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
Bot
changed the title
IsAdicCompleteIsAdicComplete
thorimur
pushed a commit
to thorimur/mathlib4
that referenced
this pull request
Nov 16, 2025
…AdicComplete` (leanprover-community#31296) In this PR, we add APIs generalizing the universal property of `IsAdicComplete`. Namely, instead of requiring a family of compatible maps `M \to N/I^n`, we only require a subfamily of maps `M \to N/I^a n`. This would be used in leanprover-community#26388. Co-authored-by: Jiedong Jiang <emailboxofjjd@163.com> Co-authored-by: Kenny Lau <kc_kennylau@yahoo.com.hk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, we add APIs generalizing the universal property of
IsAdicComplete. Namely, instead of requiring a family of compatible mapsM \to N/I^n, we only require a subfamily of mapsM \to N/I^a n. This would be used in #26388.IsAdicComplete#31295 [IsAdicComplete.lift]