Skip to content

[Merged by Bors] - feat(RingTheory/AdicCompletion): universal property of IsAdicComplete - #31295

Closed
jjdishere wants to merge 121 commits into
leanprover-community:masterfrom
jjdishere:jiedong_jiang_is_adic_complete_2
Closed

[Merged by Bors] - feat(RingTheory/AdicCompletion): universal property of IsAdicComplete#31295
jjdishere wants to merge 121 commits into
leanprover-community:masterfrom
jjdishere:jiedong_jiang_is_adic_complete_2

Conversation

@jjdishere

@jjdishere jjdishere commented Nov 5, 2025

Copy link
Copy Markdown
Collaborator

In this PR, we define the map IsAdicComplete.lift in the universal property of IsAdicComplete and show its uniqueness.


Open in Gitpod

jjdishere and others added 30 commits February 3, 2025 20:04
This reverts commit acd93bb.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions

github-actions Bot commented Nov 5, 2025

Copy link
Copy Markdown

PR summary 023a18d7e4

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ eq_lift
+ lift
+ mkQ_comp_lift
+ mk_lift
+ of_comp_lift
+ of_lift

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Nov 6, 2025
@mathlib4-dependent-issues-bot

Copy link
Copy Markdown
Collaborator

Comment thread Mathlib/RingTheory/AdicCompletion/Basic.lean Outdated
Comment thread Mathlib/RingTheory/AdicCompletion/Basic.lean Outdated
Comment thread Mathlib/RingTheory/AdicCompletion/Basic.lean Outdated
Comment thread Mathlib/RingTheory/AdicCompletion/Basic.lean Outdated

@erdOne erdOne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
maintainer merge

@github-actions

github-actions Bot commented Nov 8, 2025

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by erdOne.

@ghost ghost added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Nov 8, 2025
@riccardobrasca

Copy link
Copy Markdown
Member

Thanks!

bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Nov 8, 2025
mathlib-bors Bot pushed a commit that referenced this pull request Nov 8, 2025
…e` (#31295)

In this PR, we define the map `IsAdicComplete.lift` in the universal property of `IsAdicComplete` and show its uniqueness.

Co-authored-by: Jiedong Jiang <emailboxofjjd@163.com>
Co-authored-by: Kenny Lau <kc_kennylau@yahoo.com.hk>
@mathlib-bors

mathlib-bors Bot commented Nov 8, 2025

Copy link
Copy Markdown
Contributor

Build failed (retrying...):

mathlib-bors Bot pushed a commit that referenced this pull request Nov 8, 2025
…e` (#31295)

In this PR, we define the map `IsAdicComplete.lift` in the universal property of `IsAdicComplete` and show its uniqueness.

Co-authored-by: Jiedong Jiang <emailboxofjjd@163.com>
Co-authored-by: Kenny Lau <kc_kennylau@yahoo.com.hk>
@mathlib-bors

mathlib-bors Bot commented Nov 8, 2025

Copy link
Copy Markdown
Contributor

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title feat(RingTheory/AdicCompletion): universal property of IsAdicComplete [Merged by Bors] - feat(RingTheory/AdicCompletion): universal property of IsAdicComplete Nov 8, 2025
@mathlib-bors mathlib-bors Bot closed this Nov 8, 2025
thorimur pushed a commit to thorimur/mathlib4 that referenced this pull request Nov 16, 2025
…e` (leanprover-community#31295)

In this PR, we define the map `IsAdicComplete.lift` in the universal property of `IsAdicComplete` and show its uniqueness.

Co-authored-by: Jiedong Jiang <emailboxofjjd@163.com>
Co-authored-by: Kenny Lau <kc_kennylau@yahoo.com.hk>
mathlib-bors Bot pushed a commit that referenced this pull request Nov 19, 2025
…Homs` (#31298)

In this PR, we build every API of the module version `IsAdicComplete.lift` for the ring version `IsAdicComplete.liftRingHom`. Mainly copying APIs in #25927, #31295, #31296.
This would be used in #26388.

Co-authored-by: Jiedong Jiang <emailboxofjjd@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants