[Merged by Bors] - chore: Split Algebra.Group.Prod - #12974
Closed
YaelDillies wants to merge 9 commits into
Closed
Conversation
Move the non-additivisable declarations to a new file `Algebra.GroupWithZero.Prod`. Credit Eric for leanprover-community/mathlib3#6866 and myself for leanprover-community/mathlib3#10907.
YaelDillies
added
awaiting-review
awaiting-CI
github-actions
Bot
removed
the
awaiting-CI
YaelDillies
commented
May 17, 2024
ghost
added
the
merge-conflict
22 tasks
ghost
removed
the
merge-conflict
|
You can run this locally as follows ## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
1 task
mathlib-bors Bot
pushed a commit
that referenced
this pull request
May 20, 2024
Resplit `Algebra.BigOperators.Multiset.Basic` and `Algebra.BigOperators.Multiset.Lemmas` into two new files: * `Algebra.BigOperators.Group.Multiset` for lemmas that require group-like structures (`Monoid`, `Group`, ...) * `Algebra.BigOperators.Ring.Multiset` for lemmas that require ring-like structures (`MonoidWithZero`, `Ring`, ...) Add `assert_not_exists Ring` in the former. Once #12974 lands, it will be strenghtenable to `assert_not_exists MonoidWithZero`.
Ruben-VandeVelde
approved these changes
May 21, 2024
Ruben-VandeVelde
left a comment
Ruben-VandeVelde
left a comment
Contributor
There was a problem hiding this comment.
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
github-actions
Bot
added
the
maintainer-merge
ghost
added
ready-to-merge
mathlib-bors Bot
pushed a commit
that referenced
this pull request
May 21, 2024
Move the non-additivisable declarations to a new file `Algebra.GroupWithZero.Prod`. Credit Eric for leanprover-community/mathlib3#6866 and myself for leanprover-community/mathlib3#10907.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
Bot
changed the title
Algebra.Group.ProdAlgebra.Group.Prod
callesonne
pushed a commit
that referenced
this pull request
Jun 4, 2024
Resplit `Algebra.BigOperators.Multiset.Basic` and `Algebra.BigOperators.Multiset.Lemmas` into two new files: * `Algebra.BigOperators.Group.Multiset` for lemmas that require group-like structures (`Monoid`, `Group`, ...) * `Algebra.BigOperators.Ring.Multiset` for lemmas that require ring-like structures (`MonoidWithZero`, `Ring`, ...) Add `assert_not_exists Ring` in the former. Once #12974 lands, it will be strenghtenable to `assert_not_exists MonoidWithZero`.
callesonne
pushed a commit
that referenced
this pull request
Jun 4, 2024
Move the non-additivisable declarations to a new file `Algebra.GroupWithZero.Prod`. Credit Eric for leanprover-community/mathlib3#6866 and myself for leanprover-community/mathlib3#10907.
js2357
pushed a commit
that referenced
this pull request
Jun 18, 2024
Resplit `Algebra.BigOperators.Multiset.Basic` and `Algebra.BigOperators.Multiset.Lemmas` into two new files: * `Algebra.BigOperators.Group.Multiset` for lemmas that require group-like structures (`Monoid`, `Group`, ...) * `Algebra.BigOperators.Ring.Multiset` for lemmas that require ring-like structures (`MonoidWithZero`, `Ring`, ...) Add `assert_not_exists Ring` in the former. Once #12974 lands, it will be strenghtenable to `assert_not_exists MonoidWithZero`.
js2357
pushed a commit
that referenced
this pull request
Jun 18, 2024
Move the non-additivisable declarations to a new file `Algebra.GroupWithZero.Prod`. Credit Eric for leanprover-community/mathlib3#6866 and myself for leanprover-community/mathlib3#10907.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the non-additivisable declarations to a new file
Algebra.GroupWithZero.Prod. Credit Eric for leanprover-community/mathlib3#6866 and myself for leanprover-community/mathlib3#10907.