[Merged by Bors] - chore: Separate algebraic multiset lemmas - #12845
Closed
YaelDillies wants to merge 2 commits into
Closed
[Merged by Bors] - chore: Separate algebraic multiset lemmas#12845YaelDillies wants to merge 2 commits into
YaelDillies wants to merge 2 commits into
Conversation
YaelDillies
added
awaiting-review
awaiting-CI
ghost
added
the
blocked-by-other-PR
YaelDillies
force-pushed
the
move_multiset_ring_big_ops
branch
from
May 12, 2024 18:25
4972a17 to
7dc1961
Compare
github-actions
Bot
removed
the
awaiting-CI
Contributor
|
According to a rough "auto-diff", no declarations were lost and the only added one is |
ghost
added
merge-conflict
|
This PR/issue depends on:
|
YaelDillies
force-pushed
the
move_multiset_ring_big_ops
branch
from
May 16, 2024 18:07
c14c2fd to
7697dd6
Compare
ghost
removed
the
merge-conflict
1 task
YaelDillies
force-pushed
the
move_multiset_ring_big_ops
branch
from
May 19, 2024 06:49
125001b to
e2974c6
Compare
|
You can run this locally as follows ## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
Ruben-VandeVelde
approved these changes
May 19, 2024
Ruben-VandeVelde
approved these changes
May 20, 2024
Ruben-VandeVelde
left a comment
Ruben-VandeVelde
left a comment
Contributor
There was a problem hiding this comment.
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
github-actions
Bot
added
the
maintainer-merge
Member
|
Thanks 🎉 bors merge |
github-actions
Bot
added
ready-to-merge
mathlib-bors Bot
pushed a commit
that referenced
this pull request
May 20, 2024
Resplit `Algebra.BigOperators.Multiset.Basic` and `Algebra.BigOperators.Multiset.Lemmas` into two new files: * `Algebra.BigOperators.Group.Multiset` for lemmas that require group-like structures (`Monoid`, `Group`, ...) * `Algebra.BigOperators.Ring.Multiset` for lemmas that require ring-like structures (`MonoidWithZero`, `Ring`, ...) Add `assert_not_exists Ring` in the former. Once #12974 lands, it will be strenghtenable to `assert_not_exists MonoidWithZero`.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
Bot
changed the title
callesonne
pushed a commit
that referenced
this pull request
Jun 4, 2024
Resplit `Algebra.BigOperators.Multiset.Basic` and `Algebra.BigOperators.Multiset.Lemmas` into two new files: * `Algebra.BigOperators.Group.Multiset` for lemmas that require group-like structures (`Monoid`, `Group`, ...) * `Algebra.BigOperators.Ring.Multiset` for lemmas that require ring-like structures (`MonoidWithZero`, `Ring`, ...) Add `assert_not_exists Ring` in the former. Once #12974 lands, it will be strenghtenable to `assert_not_exists MonoidWithZero`.
js2357
pushed a commit
that referenced
this pull request
Jun 18, 2024
Resplit `Algebra.BigOperators.Multiset.Basic` and `Algebra.BigOperators.Multiset.Lemmas` into two new files: * `Algebra.BigOperators.Group.Multiset` for lemmas that require group-like structures (`Monoid`, `Group`, ...) * `Algebra.BigOperators.Ring.Multiset` for lemmas that require ring-like structures (`MonoidWithZero`, `Ring`, ...) Add `assert_not_exists Ring` in the former. Once #12974 lands, it will be strenghtenable to `assert_not_exists MonoidWithZero`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resplit
Algebra.BigOperators.Multiset.BasicandAlgebra.BigOperators.Multiset.Lemmasinto two new files:Algebra.BigOperators.Group.Multisetfor lemmas that require group-like structures (Monoid,Group, ...)Algebra.BigOperators.Ring.Multisetfor lemmas that require ring-like structures (MonoidWithZero,Ring, ...)Add
assert_not_exists Ringin the former. Once #12974 lands, it will be strenghtenable toassert_not_exists MonoidWithZero.