test: frontend +init acceptance scaffold (DO NOT MERGE) - #2075
Open
zhmushan wants to merge 9 commits into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (13)
🚧 Files skipped from review as they are similar to previous changes (10)
📝 WalkthroughWalkthrough
ChangesFrontend app type support
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
the
size/M
zhmushan
marked this pull request as ready for review
July 28, 2026 08:01
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2075 +/- ##
=======================================
Coverage 75.89% 75.89%
=======================================
Files 962 962
Lines 102085 102085
=======================================
Hits 77480 77480
Misses 18720 18720
Partials 5885 5885 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.github.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
shortcuts/apps/apps_list.go (1)
38-38: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winAdd direct coverage for the new
frontendlist filter.Please add or verify a test in
shortcuts/apps/apps_list_test.gothat invokes+list --app-type frontendand asserts the outgoingapp_type=frontendparameter. This behavior change should have an accompanying contract test.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@shortcuts/apps/apps_list.go` at line 38, Add a contract test in the apps list test suite covering the frontend filter: invoke +list with --app-type frontend and assert the outgoing request includes app_type=frontend, while preserving existing filter coverage.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@shortcuts/apps/apps_init.go`:
- Line 42: Restore the reviewed default Miaoda CLI package tag in the
miaodaCLIPkg declaration, replacing the alpha pin while preserving the existing
package variable and production init/sync flows.
---
Nitpick comments:
In `@shortcuts/apps/apps_list.go`:
- Line 38: Add a contract test in the apps list test suite covering the frontend
filter: invoke +list with --app-type frontend and assert the outgoing request
includes app_type=frontend, while preserving existing filter coverage.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 9c6d725d-2958-47e3-937b-454caa0a2260
📒 Files selected for processing (6)
shortcuts/apps/apps_create.goshortcuts/apps/apps_create_test.goshortcuts/apps/apps_init.goshortcuts/apps/apps_list.goshortcuts/apps/apps_meta.goskills/lark-apps/SKILL.md
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@a0f344012593c7bcfbc77b677c759225b0fbd876🧩 Skill updatenpx skills add larksuite/cli#test/frontend-init-alpha -y -g |
zhmushan
force-pushed
the
test/frontend-init-alpha
branch
from
July 28, 2026 11:56
036335f to
8281875
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/lark-apps/references/lark-apps-local-dev.md`:
- Around line 56-60: Update the post-commit release workflow after lark-cli apps
+release-create to invoke +release-get for the created release and verify that
status=finished before stating or proceeding as if deployment completed. Keep
the existing branch and app parameters consistent with the release creation
command.
- Line 3: 更新文档开头的适用范围说明，仅将数据库调试归于 full_stack 应用；保留 frontend 和 html
的本地开发、调试及发布范围，但不要暗示它们包含数据库调试流程。
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 3c96c737-6310-474b-9065-143e2e89131e
📒 Files selected for processing (6)
shortcuts/apps/apps_init.goskills/lark-apps/references/lark-apps-create.mdskills/lark-apps/references/lark-apps-get.mdskills/lark-apps/references/lark-apps-list.mdskills/lark-apps/references/lark-apps-local-dev.mdskills/lark-apps/references/lark-apps-release-create.md
🚧 Files skipped from review as they are similar to previous changes (1)
- shortcuts/apps/apps_init.go
6 tasks
zhmushan
force-pushed
the
test/frontend-init-alpha
branch
from
July 28, 2026 12:08
8281875 to
3ad2504
Compare
SKILL.md's routing table already covered frontend, but the per-command reference docs still enumerated only html/full_stack. Update create/list/get enum values, add a frontend local-dev section, and note frontend in the release-create entry so agents document the third app type consistently.
- create.md: state the app-type enum is matched exactly (lowercase), drop the incorrect claim that the CLI normalizes case - local-dev.md: scope database debugging to full_stack (frontend/html have no DB) and add the +release-get finished-status poll to the frontend flow
The E2E coverage table and two test comments still described the --app-type enum as html/full_stack after frontend was added. Update them to html/frontend/full_stack for consistency; assertions are unaffected (they match on substrings, not the full enum set).
zhmushan
force-pushed
the
test/frontend-init-alpha
branch
from
August 5, 2026 07:52
3ad2504 to
a0f3440
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DO NOT MERGE — acceptance scaffold only. This branch pins
apps +initto@lark-apaas/miaoda-cli@0.1.24-alpha.03a64f0(which contains thefrontend -> vite-reactmapping) so reviewers can validateapps +initon frontend apps before the miaoda-cli release lands on npmlatest.The real feature PR is #2072. This branch = #2072 + a one-line temporary version pin. It exists solely to generate a pkg.pr.new preview build for acceptance testing, and will be deleted once miaoda-cli MR #129 is published to npm
latest.Changes
shortcuts/apps/apps_init.go: temporarily pinmiaodaCLIPkgto the frontend alpha version (revert to@latestbefore any merge)Test Plan
go build ./...)apps +initon a frontend app and confirm it scaffolds a vite-react projectRelated Issues
N/A (acceptance scaffold for #2072)
Summary by CodeRabbit
New Features
frontendas a supported--app-typeforapps +createandapps +list, including updated hints/examples.Documentation
frontendworkflow, upgrading tofull_stack, and release status polling.Tests
apps +create --app-type frontendsends the correct app type.