Skip to content

XSH-867: Use None in DataFrame index/column names for missing headers #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Nov 4, 2022
Merged

XSH-867: Use None in DataFrame index/column names for missing headers #169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions gooddata-pandas/gooddata_pandas/result_convertor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ def _create_header_mapper(
dim: int,
label_overrides: Optional[LabelOverrides] = None,
use_local_ids_in_headers: bool = False,
) -> Callable[[Any, Optional[int]], str]:
) -> Callable[[Any, Optional[int]], Optional[str]]:
"""
Prepares header mapper function which is doing header structures translations into appropriate label used
in a dataframe
Expand All @@ -250,8 +250,8 @@ def _create_header_mapper(
attribute_labels = label_overrides.get("labels", {})
measure_labels = label_overrides.get("metrics", {})

def _mapper(header: Any, header_idx: Optional[int]) -> str:
label = ""
def _mapper(header: Any, header_idx: Optional[int]) -> Optional[str]:
label = None
if header is None:
pass
elif "attributeHeader" in header:
Expand Down