Skip to content

XSH-867: Use None in DataFrame index/column names for missing headers#169

Merged
1 commit merged into
gooddata:masterfrom
torchbear:xsh-867
Nov 4, 2022
Merged

XSH-867: Use None in DataFrame index/column names for missing headers#169
1 commit merged into
gooddata:masterfrom
torchbear:xsh-867

Conversation

@torchbear

Copy link
Copy Markdown
Contributor
  • because pandas.io.formats.style.Styler.to_excel expects empty headers with None otherwise it takes the value and prints it which is not expected for empty string in this case

@ghost

ghost commented Nov 4, 2022

Copy link
Copy Markdown

Build succeeded (check pipeline).

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #169 (409fde2) into master (9aedb61) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #169      +/-   ##
==========================================
+ Coverage   92.01%   92.02%   +0.01%     
==========================================
  Files          65       65              
  Lines        4231     4238       +7     
==========================================
+ Hits         3893     3900       +7     
  Misses        338      338              
Impacted Files Coverage Δ
...ooddata-pandas/gooddata_pandas/result_convertor.py 94.47% <100.00%> (ø)
gooddata-sdk/gooddata_sdk/catalog/base.py 97.29% <100.00%> (+0.07%) ⬆️
...dk/catalog/data_source/entity_model/data_source.py 99.20% <100.00%> (+0.04%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

* pandas.io.formats.style.Styler.to_excel expects empty headers
  with None otherwise it takes the value and prints it which is not
  expected for empty string in this case
@ghost

ghost commented Nov 4, 2022

Copy link
Copy Markdown

Build succeeded (check pipeline).

@hkad98 hkad98 self-requested a review November 4, 2022 07:59
@hkad98 hkad98 added the merge label Nov 4, 2022
@yenkins

yenkins commented Nov 4, 2022

Copy link
Copy Markdown

Sonar scan result

More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-python-sdk-gate-PR169

To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'.

@ghost ghost removed the merge label Nov 4, 2022
@ghost ghost merged commit 189f60f into gooddata:master Nov 4, 2022
@ghost

ghost commented Nov 4, 2022

Copy link
Copy Markdown

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants