[Pointcut] Implement return-type pointcuts for framework, #370#371
Merged
Conversation
Nitpick-CI
reviewed
Nov 22, 2017
| $pointcut = new SignaturePointcut( | ||
| PointFilter::KIND_METHOD, | ||
| $reference->getMemberNamePattern(), | ||
| $memberFilter); |
There was a problem hiding this comment.
- Multi-line function call not indented correctly; expected 16 spaces but found 20
- Closing parenthesis of a multi-line function call must be on a line by itself
|
The inspection completed: 2 new issues, 5 updated code elements |
lisachenko
added a commit
to goaop/idea-plugin
that referenced
this pull request
Apr 10, 2026
…ullable types) Adds optional return type matching to `execution()` pointcuts, matching the Go! AOP Framework syntax (goaop/framework#371). Supports simple types, nullable types (`?string`), wildcards (`*`, `**`), and fully-qualified class names. Examples: `execution(public Example->method(*): string)`, `execution(public Example->method(*): ?string)`, `execution(public Example->method(*): \Ns\Class)`. - Lexer: T_COLON (':') and T_QUESTION_MARK ('?') tokens - Grammar: `returnTypePattern` rule, optional `(':' returnTypePattern)` in `methodExecutionReference` - PSI: ReturnTypePattern interface/impl, MethodExecutionReference#getReturnTypePattern - Domain: ReturnTypeFilter (Kotlin) performs glob-pattern matching against PHP method return types, respecting nullability - Build: remove generateParser/generateLexer as automatic compile dependencies to prevent GrammarKit from overwriting manually-maintained PSI delegation methods Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends pointcut syntax to support return typehints for PHP7