Rename Jetbrains Ignore-File and Add Some Symlinks, to Improve Visibility#3349
Closed
drothmaler wants to merge 1 commit into
Closed
Rename Jetbrains Ignore-File and Add Some Symlinks, to Improve Visibility#3349drothmaler wants to merge 1 commit into
drothmaler wants to merge 1 commit into
Conversation
drothmaler
force-pushed
the
Jetbrains-Cleanup
branch
2 times, most recently
from
bf28ef8 to
35c4c6a
Compare
…lity This gitignore, only covers JetBrains products, that are based on the IntelliJ Platform. JetBrains also offers other products, that are not base on IntelliJ (e. g. Resharper) and therefore would need a totally different gitignore file. So it seems to be more appropriate to name it according to the platform instead of the company. Also the names "JetBrains" or "IntelliJ" might not be obvious to somebody looking for "GoLang" or "PhpStorm". Adding some symlinks will hopefully solve the problem and will make it easier for people to find what they are looking for.
drothmaler
force-pushed
the
Jetbrains-Cleanup
branch
from
35c4c6a to
d20b6b9
Compare
|
This PR is stale because there have been no updates in 90 days. It will close after 180 days of inactivity. Leave a comment if you want to keep it open 😄 |
|
This PR has been closed because it was inactive for 180 days. If you want to continue working on it, please open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for making this change:
The
Jetbrains.gitignore, actually only covers JetBrains products, that are based on the IntelliJ Platform.JetBrains also offers other products, that are not base on it (e. g. Resharper) and
therefore would need a totally different gitignore file.
So it seems to be more appropriate to name it according to the platform instead of the company.
Also the names "JetBrains" or "IntelliJ" might not be obvious to somebody looking for "GoLang" or "PhpStorm". I think this is one of the factors, why Pull Requests are created again an again, seeking to add IntelliJ ignore rules to all kinds of other languages or even new ignore files.
Adding some symlinks will hopefully solve the problem and will make it easier for people to find what they are looking for.