added pycharm .idea and .iml files to python git ignore#3346
added pycharm .idea and .iml files to python git ignore#3346michalslowikowski00 wants to merge 2 commits into
Conversation
|
We maintain a Global/JetBrains.gitignore template here that covers everything you should need. |
|
But maybe it's worth to add it to assume that a lot of people want to use it ? there is no harm in it. |
|
I don't manage this project, so I don't have an opinion.Here is similar PR about Python + VSCode: #3317 |
|
I think it would be good to add it also to Golang .gitignore |
|
The problem is, once you go down that road, you would have to add it to many more files...
And why not also add ... As you can see, just because 'a lot of people want to use it', doesn't mean it's a good idea, to mix it all together. This repo is modular. There are small, maintainable gitignore files for Tools, Languages, BuildSystem, Editors, IDEs, OperatingSystems and probably more. And you can combine them, to tailor a custom gitignore specific for all your Projects needs (e.g. using gitignore.io). |
|
So why don't we describe this principle and link to gihub.io prominently in the README ? That would save a lot of hassle and there will be far less LetsCombineAllThingsTogether-PRs, I created PR for that #3348 |
|
Thanks everyone for the discussion on this. I've been meaning to rewrite the README for a while to address some things but it keeps getting bumped down my priority queue. Hearing this context from everyone helps me to understand what I need to communicate to everyone. I'm going to close out this PR given we have #3348 open for improving the README and #3349 to improve how the JetBrains products are listed here, stay tuned! |
|
See #3451 for an optional solution |
Reasons for making this change:
There are missing files for PyCharm IDE:
.ideaand*.iml.Links to documentation supporting these rule changes:
I couldn't find docs about why I should ignore these files, but here are two links with discussion about it.
https://intellij-support.jetbrains.com/hc/en-us/community/posts/115000154070-How-to-gitignore-idea-files
intellij-rust/intellij-rust#1570
If this is a new template:
https://www.jetbrains.com/pycharm/