feat(android): use FlutterFragmentActivity and AppCompat LaunchTheme for biometrics - #6758
Closed
mccre110 wants to merge 4 commits into
Closed
feat(android): use FlutterFragmentActivity and AppCompat LaunchTheme for biometrics#6758mccre110 wants to merge 4 commits into
mccre110 wants to merge 4 commits into
Conversation
Switch the dev client and flet build template to FlutterFragmentActivity, which local_auth requires for biometric dialogs on Android. Re-parent LaunchTheme to Theme.AppCompat.DayNight.NoActionBar in light and night styles so the biometric dialog does not crash on API 24-27. Add a biometric cross-platform permission bundle for NSFaceIDUsageDescription on iOS and macOS builds, document FlutterFragmentActivity R8 keep rules, and note Touch ID signing requirements in macOS publish docs. Co-authored-by: Corey McCrea <mccre110@users.noreply.github.com>
Co-authored-by: Corey McCrea <mccre110@users.noreply.github.com>
Co-authored-by: Corey McCrea <mccre110@users.noreply.github.com>
Remove flet-local-auth references from the host PR so docs build passes before the extension lands. Co-authored-by: Corey McCrea <mccre110@users.noreply.github.com>
|
|
Contributor
|
The PR looks like a "base" for another one? |
Author
Contributor
|
Got it. Let's close this PR and review #6759 then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Android host infrastructure required for biometric authentication and other plugins that need a
FragmentActivity(e.g.local_auth).Changes:
FlutterActivity→FlutterFragmentActivityin the dev client andflet buildtemplateLaunchThemeparent →Theme.AppCompat.DayNight.NoActionBar(light + night) so biometric dialogs work on API 24–27biometriccross-platform permission bundle (NSFaceIDUsageDescriptionfor iOS/macOS)Info.plist## Unreleased→ ImprovementsThis PR is intentionally separate from the
flet-local-authextension so the host-app blast radius can be reviewed and reverted independently. The extension PR stacks on this one.Related: closes #3192 (supersedes closed #3682) and #5226.
Test code
Type of change
Checklist
website/sidebars.ymlfor breaking changes, removals, and deprecations, if applicable.Screenshots
N/A — host/template change; no UI change beyond correct biometric dialog behavior on Android.
Additional details
N/A
Summary by Sourcery
Update Android host apps and templates to support biometric authentication and add a cross-platform biometric permission bundle with accompanying documentation and changelog entry.
New Features:
biometriccross-platform permission bundle that injects Face ID usage descriptions for iOS and macOS builds.Enhancements:
FlutterFragmentActivityto support plugins requiring a FragmentActivity, such as biometric authentication.LaunchTheme(Theme.AppCompat.DayNight.NoActionBar) for Android launch screens in the dev client and templates to ensure biometric dialogs work correctly on older API levels.Documentation:
biometricpermission bundle behavior for macOS, including how to override Face ID usage descriptions.