Added Local Authentication support. - #3682
Conversation
Reviewer's Guide by SourceryThis pull request introduces local authentication support across Android, iOS, and Windows platforms using the local_auth package. It includes updates to the Android client, new Dart and Python files for the LocalAuthentication control, and initial documentation for the new feature. File-Level Changes
Tips
|
There was a problem hiding this comment.
Hey @vv2006-mc - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 5 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
|
@sourcery-ai review |
There was a problem hiding this comment.
Hey @vv2006-mc - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 8 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 1 issue found
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
|
@vv2006-mc Thanks for your contribution! |
|
@ndonkoHenri the integration for Android, iOS, and Windows is completed. I am currently searching for ways to integrate with macOS and Linux. I will notify you when integrating macOS and Linux is completed. |
|
@ndonkoHenri if you have access to physical linux machine, can you please check if the linux implementation works? |
|
I don't have one, sorry. |
|
@ndonkoHenri os what do we do now? |
|
If you are done I could start reviewing and testing with my devices. |
|
@ndonkoHenri For linux I only tested in a virtual machine so I am not that sure if it will work properly. |
|
@ndonkoHenri I can't figure out what went wrong can you help me a bit when you are free? And sorry for the force-push my computer crashed while I was running a command in git and somehow pushed that. |
|
Why close @Vivekananda-Mullangi ? |
|
I am trying to make a better version @ndonkoHenri, I will open an other pr with that when it is done. This approach is using python to provide support for linux, but there is a way to do that directly from flutter by using And |
|
Awesome! 🔥 |
Description
Added support for local authentication using https://pub.dev/packages/local_auth.
Supporting Platforms: android, ios, windows.
Local authentication uses the registered password (or pin or pattern) and biometrics (Fingerprint and Face on Android, FaceId on IOS, not supported on windows) to verify if the actual owner of the device or someone who has access to the device is the one accessing the sensitive data stored in the app.
Example use cases: bank app, password manager
Fixes #3192
Test Code
title: title to be displayed when prompted to authenticate
biometricsOnly: gives the user option to authenticate using only biometrics(NOT SUPPORTED ON WINDOWS)
useErrorDialogs: Whether the system will attempt to handle user-fixable issues encountered while authenticating. For instance, if a fingerprint reader exists on the device but there's no fingerprint registered, the plugin might attempt to take the user to settings to add one.
Type of change
Checklist:
Screenshots (if applicable):
Additional details
Summary by Sourcery
This pull request introduces local authentication support across Android, iOS, and Windows platforms using the local_auth package. It includes updates to the Android client, new Dart and Python files for the LocalAuthentication control, and corresponding documentation.