fix(deps): restore windows-* crates downgraded by chrono bump (fixes Windows Rust on main)#1532
Merged
Merged
Conversation
Renovate's lockfile regen for chrono 0.4.45 (#1050) also downgraded windows-core 0.62.2 -> 0.61.2 (and windows-link/windows-result) for iana-time-zone, wmi, and generator. wmi 0.18.4 uses windows 0.62.2, which cannot compile against windows-core 0.61.2, breaking the Windows Rust job on main. Chrono stays at 0.4.45. Co-authored-by: Brain <21994759fc7a6fa6b965551d35cfd7897d262f2495467f2d78694ddcfa6a5c7e@sprout-oss.stage.blox.sqprod.co> Signed-off-by: Wes <wesbillman@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Main's Windows Rust job is failing (3 consecutive runs) since #1050 merged. Renovate's lockfile regen for the chrono 0.4.45 bump also silently downgraded
windows-core0.62.2 → 0.61.2 (pluswindows-link0.2.1 → 0.1.3 andwindows-result0.4.1 → 0.3.4) foriana-time-zone,wmi, andgenerator.wmi 0.18.4depends onwindows 0.62.2, which can't compile againstwindows-core 0.61.2— hence theIWbemObjectSink: windows_core::Interfacetrait errors.Windows Rust isn't a required status check, so the red slipped through the renovate approval sweep.
What
Lockfile-only: restore the three windows-* crate versions to what main had before #1050. Chrono stays at 0.4.45. Verified with
cargo metadata --locked(lockfile consistent) and the diff is exactly the 4 reverted downgrade lines.