chore(deps): update rust crate chrono to v0.4.45#1531
Closed
wesbillman wants to merge 1 commit into
Closed
Conversation
Renovate's attempt (#1050) failed Windows clippy: re-resolving chrono dragged iana-time-zone and wmi down to windows-core 0.61.2 and generator down to windows-link 0.1/windows-result 0.3, breaking wmi compilation. Bump generator to 0.8.9 alongside and keep iana-time-zone and wmi on windows-core 0.62.2 (both requirements allow it) so the lockfile stays on the newer windows crates. Co-authored-by: Pinky <44b8e82baa6e0e254e0208d68f335c283c94e7b78dd1fa10d5a49d3f13dd0435@sprout-oss.stage.blox.sqprod.co> Signed-off-by: Wes <wesbillman@users.noreply.github.com>
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Renovate #1050 (chrono 0.4.44 → 0.4.45) fails the Windows Rust clippy job:
could not compile wmi (lib) due to 16 previous errors.Root cause: chrono 0.4.45 bumps its
windows-linkrequirement to^0.2, and cargo's re-resolution during renovate'scargo update chronoalso collapsed unrelated duplicate windows crates downward —iana-time-zoneandwmidropped fromwindows-core 0.62.2to0.61.2, andgeneratordropped towindows-link 0.1.3/windows-result 0.3.4.wmi 0.18.4doesn't compile against the olderwindows-coreinterface traits.What
Same chrono bump, minus the collateral downgrades (
Cargo.lockonly):chrono0.4.44 → 0.4.45generator0.8.8 → 0.8.9 (restoreswindows-link 0.2.1/windows-result 0.4.1)iana-time-zoneandwmikept onwindows-core 0.62.2— both requirements allow it (>=0.56, <=0.62and>=0.59, <0.63)Supersedes #1050; renovate will detect 0.4.45 on main and close it.
Verification
cargo update chrono --precise 0.4.45cargo metadata --lockedpasses — lockfile self-consistentcargo clippy --workspace --lockedclean locally (macOS); the Windows clippy job on this PR's CI is the authoritative check for the original failure