fix(ci): restore main to green — tauri fmt, personas.rs file-size split, Windows path test#1399
Merged
Conversation
Apply `cargo fmt` to the desktop/src-tauri crate to clear the failing "Desktop Tauri format check" CI step on main. Pure formatting (rustfmt line-wrapping); no logic changes. Co-authored-by: Brain <21994759fc7a6fa6b965551d35cfd7897d262f2495467f2d78694ddcfa6a5c7e@sprout-oss.stage.blox.sqprod.co> Signed-off-by: Wes <wesbillman@users.noreply.github.com>
personas.rs (2018 lines) was over the desktop file-size cap (carve-out
of 1279). Split the write-back code (find_team_for_persona_source,
write_back_persona_md, rewrite_persona_md + its tests) into
commands/personas/writeback.rs and the inbound-reconcile tests into
commands/personas/inbound_tests.rs. Pure relocation: the public command
surface is identical (all 8 #[tauri::command] fns unchanged, update_persona
call site unchanged); write_back_persona_md is now pub(super) so the parent
module can call it. Removes the personas.rs size carve-out — no file needs it.
Also fix the Windows-only failure in test_writeback_uses_manifest_path_not_convention:
assert on path components (file_name / parent file_name) instead of a
string .contains("personas/..."), which fails on Windows' `\` separator.
Test-only; the production write-back path uses source_path as a PathBuf and
is already cross-platform.
Co-authored-by: Brain <21994759fc7a6fa6b965551d35cfd7897d262f2495467f2d78694ddcfa6a5c7e@sprout-oss.stage.blox.sqprod.co>
Signed-off-by: Wes <wesbillman@users.noreply.github.com>
wesbillman
changed the title
wpfleger96
pushed a commit
that referenced
this pull request
Jun 30, 2026
…work * origin/main: (25 commits) fix(thread): stop mid-scroll content jump in live threads (#1397) fix(ci): restore main to green — tauri fmt, personas.rs file-size split, Windows path test (#1399) fix(desktop): enable buzz-dev-mcp MCP server for Codex agents (#1394) fix(ci): restore E2E flakiness fixes for pgschema, docker-pull, and spec timing (#1396) fix(personas): persist pack-backed persona UI edits across reboot (#1392) fix(buzz-acp): clear steer_rx on all run_prompt_task exit paths (#1391) Restore channel date divider rule (#1395) Speed up profile wave action (#1379) Restore visible links for rich previews (#1378) Mobile channel list polish (#1367) style(desktop): unify corner radii to rounded-2xl (16px) (#1393) fix(desktop): skip keychain write when blob contents are unchanged (#1377) fix(desktop): stop clipping the agent-activity row under the composer (#1371) Constrain macOS overscroll to conversations (#1317) Mobile appearance foundation (#1366) chore(release): release Buzz Desktop version 0.3.38 (#1375) feat(desktop): provider-agnostic model selection + databricks discovery (#1307) release(helm): buzz chart 0.1.1 (#1374) Harden relay attack surfaces (#1369) ci(helm): publish chart to GHCR on chart-v* tags (#1372) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores
mainto green after #1392's merge landed three CI breakages thatthe pre-merge checks didn't catch. All three are fixed here.
1. Desktop Tauri format check (Rust Lint)
desktop/src-tauri/src/commands/personas.rswas never rustfmt'd against thetauri crate. CI Rust Lint runs two independent rustfmt passes — root
just fmt-checkandjust desktop-tauri-fmt-check(thesrc-tauricrateis its own manifest the root
--alldoesn't cover); the second pass failed.Fix:
cargo fmton the crate. Pure formatting — token-level comparison showszero identifier/logic/string changes.
2. Desktop file-size guard (Desktop Core)
personas.rswas 2018 lines, over its 1279 carve-out indesktop/scripts/check-file-sizes.mjs. Rather than bump the limit, split thefile and remove the carve-out entirely:
commands/personas/writeback.rs—find_team_for_persona_source,write_back_persona_md,rewrite_persona_md+ their testscommands/personas/inbound_tests.rs— inbound-reconcile testscommands/personas/mod.rs— the restPure relocation: all 8
#[tauri::command]fns and theupdate_personacallsite are unchanged. The only visibility change is
write_back_persona_md→pub(super)so the parent module can still call it across the new boundary.3. Windows Rust test failure
test_writeback_uses_manifest_path_not_conventionassertedsource_path.to_string_lossy().contains("personas/..."), which fails onWindows'
\separator. Fixed to assert on path components (file_name/parent().file_name()). Test-only — the production write-back path usessource_pathas aPathBufand was already cross-platform.Verification
cargo checkclean (no warnings).pnpm check:file-sizesexit 0 with the carve-out removed.