Mobile appearance foundation#1366
Conversation
![chatgpt-codex-connector[bot]](https://avatars.github.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 49f608fc7e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
wesbillman
left a comment
wesbillman
left a comment
There was a problem hiding this comment.
Thanks — the Inter/font asset registration and gutter changes look mechanically sound, and the mobile checks pass locally. I do see one user-visible regression to fix before merge:
CHANGE: the new default accent migrates every unset/legacy default accent to index 8 (Black), and that accent is Color(0xFF000000) for both light and dark. For any user who already selected a dark named scheme (or later selects one while leaving the default accent alone), resolveSchemes() forces dark mode for that scheme, then applyAccent() replaces the scheme's readable primary/foreground accent with black. Several theme consumers draw selected/navigation affordances directly with scheme.primary on dark surfaces — e.g. NavigationBarThemeData.iconTheme uses scheme.primary for selected icons on scheme.surface, and chip selected fill uses scheme.primary. On github-dark (surface around #24292E), black is ~1.4:1 contrast and selected state becomes nearly invisible.
Repro from prefs after this change: buzz_color_scheme=github-dark and buzz_accent_color absent or legacy -1 → AccentNotifier.build() returns/migrates to defaultAccentIndex → applyAccent(..., Black) sets primary=#000000 in the dark scheme.
Please either keep the legacy/default “use scheme primary” behavior for non-default/dark schemes, make the default accent adaptive/neutral (dark side uses the theme foreground/white rather than black), or otherwise avoid applying black as the default primary in dark forced schemes.
Validation I ran:
PATH="$PWD/bin:$PATH" just mobile-check✅PATH="$PWD/bin:$PATH" just mobile-test✅ (393 passed, 1 skipped)git diff --check origin/main...HEAD✅
|
🤖 Addressed @wesbillman's requested change in I also replied to and resolved the inline Codex thread. Ready for re-review. Validation:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5309404677
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| child: Padding( | ||
| padding: const EdgeInsets.symmetric( | ||
| horizontal: Grid.xs, | ||
| horizontal: Grid.gutter, |
There was a problem hiding this comment.
When a pulse note is shown on a 320dp-wide device, the list now has 20dp side gutters and the avatar row leaves the action Row about 228dp wide; with this per-button padding the four actions need at least 224dp before any label, and a nonzero reaction count adds enough text width to overflow. This only shows up for notes with reactions on small phones, but it is introduced by widening the compact action buttons, so keep these buttons on the old tighter padding or make the row flex/wrap.
Useful? React with 👍 / 👎.
…work * origin/main: (25 commits) fix(thread): stop mid-scroll content jump in live threads (#1397) fix(ci): restore main to green — tauri fmt, personas.rs file-size split, Windows path test (#1399) fix(desktop): enable buzz-dev-mcp MCP server for Codex agents (#1394) fix(ci): restore E2E flakiness fixes for pgschema, docker-pull, and spec timing (#1396) fix(personas): persist pack-backed persona UI edits across reboot (#1392) fix(buzz-acp): clear steer_rx on all run_prompt_task exit paths (#1391) Restore channel date divider rule (#1395) Speed up profile wave action (#1379) Restore visible links for rich previews (#1378) Mobile channel list polish (#1367) style(desktop): unify corner radii to rounded-2xl (16px) (#1393) fix(desktop): skip keychain write when blob contents are unchanged (#1377) fix(desktop): stop clipping the agent-activity row under the composer (#1371) Constrain macOS overscroll to conversations (#1317) Mobile appearance foundation (#1366) chore(release): release Buzz Desktop version 0.3.38 (#1375) feat(desktop): provider-agnostic model selection + databricks discovery (#1307) release(helm): buzz chart 0.1.1 (#1374) Harden relay attack surfaces (#1369) ci(helm): publish chart to GHCR on chart-v* tags (#1372) ...
2 participants
Summary
Snapshots
GitHub Light, black accent, and Inter default on the home surface.
Home surface with Inter metrics and 20px gutters.
Checks
cd mobile && ../bin/dart format --output=none --set-exit-if-changed libcd mobile && ../bin/flutter analyzecd mobile && ../bin/flutter test test/shared/widgets/filter_chip_bar_test.dart/private/tmpdisk exhaustion.