Skip to content

[SM-999] Add Bulk Move to Project Action#6665

Closed
justindbaur wants to merge 14 commits into
mainfrom
sm-bulk-move-to-project
Closed

[SM-999] Add Bulk Move to Project Action#6665
justindbaur wants to merge 14 commits into
mainfrom
sm-bulk-move-to-project

Conversation

@justindbaur

@justindbaur justindbaur commented Oct 23, 2023

Copy link
Copy Markdown
Member

Type of change

- [ ] Bug fix
- [x] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Add menu item on secrets list to allow the user to select multiple secrets and reassign their projects in one action. This works in conjunction to #6652 where people can import secrets without a project assignment and then they can assign them all to the project they want them a part of.

Server PR: bitwarden/server#3370

Code changes

  • apps/web/src/locales/en/messages.json: Translation strings
  • bitwarden_license/bit-web/src/app/secrets-manager/secrets/dialog/secret-move-project.component.html: Simple dialog component that allows the user to select from all the projects in their organization.
  • bitwarden_license/bit-web/src/app/secrets-manager/secrets/dialog/secret-move-project.component.ts: Logic behind the above component that will show a summary of changes about to be made when the user selects a project. Also calls the server when the user clicks move.
  • bitwarden_license/bit-web/src/app/secrets-manager/shared/secrets-list.component.html: Menu item for starting this action from the secrets list component in the header of the table.

Screenshots

Screen.Recording.2023-12-01.at.8.51.09.AM.mov

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@github-actions github-actions Bot added the needs-qa Marks a PR as requiring QA approval label Oct 23, 2023
@justindbaur
justindbaur marked this pull request as ready for review October 23, 2023 11:29
@justindbaur
justindbaur requested a review from a team as a code owner October 23, 2023 11:29
@bitwarden-bot

bitwarden-bot commented Oct 23, 2023

Copy link
Copy Markdown
Collaborator

Logo
Checkmarx One – Scan Summary & Details2223ff03-14e0-4b42-ba9b-8d0322522380

No New Or Fixed Issues Found

@justindbaur justindbaur changed the title Add Bulk Move to Project Action [SM-999] Add Bulk Move to Project Action Oct 23, 2023

@Thomas-Avery Thomas-Avery left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things to take a look at.

To note, I had to merge main in locally for both clients and server to get things running.

Comment thread apps/web/src/locales/en/messages.json Outdated
Comment thread apps/web/src/locales/en/messages.json Outdated

@Thomas-Avery Thomas-Avery left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

One thing to take a look at and this should be good to go.

justindbaur and others added 2 commits January 4, 2024 07:44
Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>
@codecov

codecov Bot commented Jan 26, 2024

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.41%. Comparing base (3a92546) to head (a8f3ebc).
⚠️ Report is 4982 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6665   +/-   ##
=======================================
  Coverage   63.41%   63.41%           
=======================================
  Files         798      798           
  Lines       22515    22515           
  Branches     4489     4489           
=======================================
  Hits        14278    14278           
  Misses       7406     7406           
  Partials      831      831           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Thomas-Avery Thomas-Avery left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-qa Marks a PR as requiring QA approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants