[SM-999] Add Bulk Move to Project Action#6665
Closed
justindbaur wants to merge 14 commits into
Closed
Conversation
Collaborator
|
No New Or Fixed Issues Found |
Thomas-Avery
suggested changes
Dec 27, 2023
Thomas-Avery
left a comment
Contributor
There was a problem hiding this comment.
A few minor things to take a look at.
To note, I had to merge main in locally for both clients and server to get things running.
…og/secret-move-project.component.ts Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>
Thomas-Avery
suggested changes
Jan 3, 2024
Thomas-Avery
left a comment
Contributor
There was a problem hiding this comment.
Looking good.
One thing to take a look at and this should be good to go.
Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6665 +/- ##
=======================================
Coverage 63.41% 63.41%
=======================================
Files 798 798
Lines 22515 22515
Branches 4489 4489
=======================================
Hits 14278 14278
Misses 7406 7406
Partials 831 831 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Type of change
Objective
Add menu item on secrets list to allow the user to select multiple secrets and reassign their projects in one action. This works in conjunction to #6652 where people can import secrets without a project assignment and then they can assign them all to the project they want them a part of.
Server PR: bitwarden/server#3370
Code changes
move.Screenshots
Screen.Recording.2023-12-01.at.8.51.09.AM.mov
Before you submit