[BEEEP][SM-997] Add appsettings.json Importer Option#6652
Closed
justindbaur wants to merge 8 commits into
Closed
Conversation
Rename to appsettings-json, fix default importer not showing options.
justindbaur
marked this pull request as ready for review
October 20, 2023 20:43
appsettings.json Importer Optionappsettings.json Importer Option
Collaborator
|
Fixed Issues
|
justindbaur
force-pushed
the
add-key-value-pair-importer
branch
from
December 15, 2023 14:04
fa9bf62 to
e5cf8db
Compare
justindbaur
removed request for
a team,
gbubemismith,
jlf0dev and
vincentsalucci
December 15, 2023 14:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Type of change
Objective
Adds an importer option for importing general JSON into a series of key-value pairs. Example files that this importer is designed to handle can be found in our own server repo. This is essentially a rewrite of how JSON configuration works in .NET (see). The only rule is that it has to be valid JSON with no comments and the top level node must be an object.
Screen.Recording.2023-10-20.at.3.22.18.PM.mov
I also took the opportunity to rework the code a bit to make it even easier to add additional importers. Another example could be a
.envfile format.Code changes
Screenshots
Before you submit