PRO-8493: inject admin UI styles for layout - #5116
Merged
Merged
Conversation
ValJed
approved these changes
Oct 23, 2025
| }, | ||
| async loadAndProcessStylesFromScene({ build, scene }) { | ||
| const pathSegments = [ 'ui', build, 'layout.css' ]; | ||
| const cssFilePath = path.join(__dirname, ...pathSegments); |
Contributor
There was a problem hiding this comment.
Detail but don't really see the need of pathSegments const
Contributor
Author
There was a problem hiding this comment.
I'll let it slide for now, because saving review time is a bigger win :D
| return self.processCss(cssContent, scene); | ||
| }, | ||
| async processCss(cssContent) { | ||
| async processCss(cssContent, scene = null) { |
haroun
added a commit
that referenced
this pull request
Oct 29, 2025
…ation * main: (23 commits) PRO-8538: fix layout bug in mobile breakpoint preview that causes tiny collapsed columns (#5127) give color button a testable data attr (#5124) PRO-8530 autodetect ES bundles (#5120) Emphasize but unfocus in layout mode (#5125) Simplify layout max width (#5123) max width, anchors, labels (#5122) refactor and inject admin UI styles for layout (#5116) Color field swatches (#5118) Pro 8285 login case insensitive (#5100) fix paste bug (#5119) Implement change outlined on Discord (#5117) PRO-8374: Mute tooltip when edit is disabled (#5114) fix sticky when controls are disabled (#5115) enable logout and whoami routes if localLogin is false (#5098) add locale picker (#5090) enforce empty state font (#5113) sticky controls (#5106) Layout widget icon (#5112) Feature layout widget (#5031) PRO-8435: log what widget type was missing (#5110) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor and inject admin UI styles for layout
What are the specific steps to test this change?
Content edit mode of layout should be responsive and behave the same as the public scene.
What kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements:
If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information: