Skip to content

Pro 8285 login case insensitive - #5100

Merged
boutell merged 20 commits into
mainfrom
pro-8285-login-case-insensitive
Oct 23, 2025
Merged

boutell merged 20 commits into
mainfrom
pro-8285-login-case-insensitive

Conversation

@ValJed

@ValJed ValJed commented Oct 9, 2025 •

Copy link
Copy Markdown
Contributor

Summary

Adds option to make login username / email case insensitive.

What are the specific steps to test this change?

When option caseInsensitve is set to true a migration is run to make all users usernames / emails case insensitive. If a conflicts occurs we log an errors with the needed infos to fix the situation.

If option is disabled the migration is removed (will be re run if option is re set to true).

  • usernames / emails are normalized when inserted in docs and safe collections.
  • When verifying logins we normalize user input if option is true.

What kind of change does this PR introduce?

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Build-related changes
  • Other

Make sure the PR fulfills these requirements:

  • It includes a) the existing issue ID being resolved, b) a convincing reason for adding this feature, or c) a clear description of the bug it resolves
  • The changelog is updated
  • Related documentation has been updated
  • Related tests have been updated

@ValJed ValJed self-assigned this Oct 9, 2025
@ValJed
ValJed marked this pull request as draft October 9, 2025 06:58
@linear

linear Bot commented Oct 9, 2025

Copy link
Copy Markdown

@ValJed
ValJed force-pushed the pro-8285-login-case-insensitive branch 3 times, most recently from de48d04 to de2aa2c Compare October 15, 2025 09:20
Comment thread modules/@apostrophecms/login/index.js
Comment thread modules/@apostrophecms/login/index.js
Comment thread modules/@apostrophecms/login/index.js
Comment thread modules/@apostrophecms/login/index.js
@ValJed
ValJed requested a review from boutell October 15, 2025 09:26
@ValJed
ValJed force-pushed the pro-8285-login-case-insensitive branch from 5536dce to 00bc68e Compare October 15, 2025 09:30
@ValJed
ValJed marked this pull request as ready for review October 15, 2025 09:31
@ValJed
ValJed removed the request for review from boutell October 15, 2025 09:51
@ValJed
ValJed requested a review from boutell October 15, 2025 10:01
Comment thread modules/@apostrophecms/login/index.js Outdated
Comment thread modules/@apostrophecms/login/index.js Outdated
Comment thread modules/@apostrophecms/migration/index.js Outdated
Comment thread modules/@apostrophecms/user/index.js
@ValJed
ValJed requested a review from boutell October 16, 2025 09:26
Comment thread modules/@apostrophecms/login/index.js Outdated
Comment thread modules/@apostrophecms/login/index.js Outdated
Comment thread modules/@apostrophecms/login/index.js
Comment thread modules/@apostrophecms/login/index.js Outdated
Comment thread test/login.js
@ValJed
ValJed force-pushed the pro-8285-login-case-insensitive branch from 064fd9f to 200da56 Compare October 16, 2025 15:12
…ue criteria, update error with conflicting fields
@ValJed
ValJed force-pushed the pro-8285-login-case-insensitive branch from 200da56 to 4a37dbb Compare October 16, 2025 15:13
@ValJed
ValJed requested a review from boutell October 16, 2025 16:35

@boutell boutell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor stuff now.

Comment thread CHANGELOG.md Outdated
Comment thread modules/@apostrophecms/login/index.js
Comment thread modules/@apostrophecms/login/index.js
Comment thread modules/@apostrophecms/login/index.js Outdated
@ValJed
ValJed force-pushed the pro-8285-login-case-insensitive branch from 9feb6a3 to a36d22b Compare October 20, 2025 08:47
@ValJed
ValJed requested a review from boutell October 20, 2025 08:49
Comment thread CHANGELOG.md Outdated
@ValJed
ValJed requested a review from boutell October 23, 2025 14:13
@boutell
boutell merged commit 03b1498 into main Oct 23, 2025
9 checks passed
@boutell
boutell deleted the pro-8285-login-case-insensitive branch October 23, 2025 14:22
@boutell

boutell commented Oct 23, 2025

Copy link
Copy Markdown
Member

Merged because I know you're busy

haroun added a commit that referenced this pull request Oct 29, 2025
…ation

* main: (23 commits)
  PRO-8538: fix layout bug in mobile breakpoint preview that causes tiny collapsed columns (#5127)
  give color button a testable data attr (#5124)
  PRO-8530 autodetect ES bundles (#5120)
  Emphasize but unfocus in layout mode (#5125)
  Simplify layout max width (#5123)
  max width, anchors, labels (#5122)
  refactor and inject admin UI styles for layout (#5116)
  Color field swatches (#5118)
  Pro 8285 login case insensitive (#5100)
  fix paste bug (#5119)
  Implement change outlined on Discord (#5117)
  PRO-8374: Mute tooltip when edit is disabled (#5114)
  fix sticky when controls are disabled (#5115)
  enable logout and whoami routes if localLogin is false (#5098)
  add locale picker (#5090)
  enforce empty state font (#5113)
  sticky controls (#5106)
  Layout widget icon (#5112)
  Feature layout widget (#5031)
  PRO-8435: log what widget type was missing (#5110)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants