Fix scheme detection via port for regex remap#12637
Merged
Merged
Conversation
The ternary operator was checking literal 80 instead of request_port == 80, making an accidental tautology that always returned the HTTP scheme. This was introduced in the apache#12243 URL std::string_view refactor.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a critical bug in the URL rewriting logic where the scheme determination for empty schemes was using an incorrect condition. The fix ensures that the request port is properly checked when deciding between HTTP and HTTPS schemes.
- Corrected the ternary operator condition to actually evaluate
request_port == 80instead of just the literal80
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
serrislew
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ternary operator was checking literal 80 instead of request_port == 80, making an accidental tautology that always returned the HTTP scheme. This was introduced in the #12243 URL std::string_view refactor.
For reference, here's a link to the previous code:
https://github.com/apache/trafficserver/pull/12243/files#diff-4ba856cb52d86339783fd72f06f834f43ef3c1225c45ec735353fdd7b9aa1da4L1021