Cleanup: Use string_view in URL and HTTPHdr

[hnakamur]

No description provided.

[bryancall]

[approve ci]

[hnakamur]

merged master and resolved conflicts.

[hnakamur]

AuTest 1of4 failed with the following output.

   Run: ipallow-56 @action=add_deny  @method=GET  
   ip_allow:
     - apply: in
       ip_addrs: [0/0, ::/0]
       action: deny
       methods: [GET, POST]
   : Failed
     Starting TestRun 184-tr : Waiting for Process "ts-181" to become ready - Failed

However all autest test cases passed on my local machine.

[bryancall]

[approve ci]

[bryancall]

Rerunning CI before I merge the PR.

[bryancall]

@hnakamur it looks like there are a couple minor errors from the recent CI build. I have reviewed the code and it looks good besides these new issues:

In file included from ../src/iocore/cache/CacheEvacuateDocVC.cc:33:
../src/iocore/cache/P_CacheInternal.h:515:33: error: too many arguments to function call, expected 0, have 1
  key->hostname = url->host_get(&key->hostlen);
                  ~~~~~~~~~~~~~ ^~~~~~~~~~~~~
../include/proxy/hdrs/URL.h:571:6: note: 'host_get' declared here
URL::host_get() const noexcept
     ^
In file included from ../src/iocore/cache/CacheEvacuateDocVC.cc:33:
../src/iocore/cache/P_CacheInternal.h:515:19: error: assigning to 'const char *' from incompatible type 'std::string_view' (aka 'basic_string_view<char>')
  key->hostname = url->host_get(&key->hostlen);
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 errors generated.

../src/iocore/cache/P_CacheInternal.h:515:33: error: too many arguments to function call, expected 0, have 1
  key->hostname = url->host_get(&key->hostlen);
                  ~~~~~~~~~~~~~ ^~~~~~~~~~~~~
../include/proxy/hdrs/URL.h:571:6: note: 'host_get' declared here
URL::host_get() const noexcept
     ^
In file included from ../src/iocore/cache/CacheDir.cc:27:
../src/iocore/cache/P_CacheInternal.h:515:19: error: assigning to 'const char *' from incompatible type 'std::string_view' (aka 'basic_string_view<char>')
  key->hostname = url->host_get(&key->hostlen);
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 errors generated.

../src/iocore/cache/P_CacheInternal.h:515:33: error: too many arguments to function call, expected 0, have 1
  key->hostname = url->host_get(&key->hostlen);
                  ~~~~~~~~~~~~~ ^~~~~~~~~~~~~
../include/proxy/hdrs/URL.h:571:6: note: 'host_get' declared here
URL::host_get() const noexcept
     ^
In file included from ../src/iocore/cache/CacheHttp.cc:25:
../src/iocore/cache/P_CacheInternal.h:515:19: error: assigning to 'const char *' from incompatible type 'std::string_view' (aka 'basic_string_view<char>')
  key->hostname = url->host_get(&key->hostlen);
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 errors generated.

[hnakamur]

I successfully compiled commit c32024e on my Ubuntu PC.

However, the CI environment is encountering a compilation error that I haven't been able to resolve:

../src/iocore/cache/P_CacheInternal.h:515:33: error: too many arguments to function call, expected 0, have 1

I've noticed a discrepancy: the error message refers to line 515 of P_CacheInternal.h, but the linked commit (c32024e) only has 507 lines in that file.

[hnakamur]

I merged the current master and I am able to reproduce the compile errors now.
I'm going to resolve the errors.

[bryancall]

[approve ci]