test: add tests for escape-hex-write-handler - #1001
Open
nkuprins wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #1000
Purpose of the pull request
EscapeHexCellWriteHandlerhas no tests. It used to have them, but they were deleted by accident (read #1000).This PR is not a blind restore of those lost tests! I took a different approach; for example,
@ParameterizedTestwere used for better scalability and readability, etc.What's changed?
_xHHHH_to_x005F_xHHHH_) and eight that must be left exactly as typed.STRINGcell data, a nullWriteCellData, and aSTRINGholding a null value.@ExcelFormatSource: write a file through Fesod with the handler registered, read it back, and require the caller's literal. It sits in its own class taggedROUND_TRIP, which keeps the rest taggedUNIT.Checklist